Drop old consul version and implement new ACL (token) endpoints #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 18, 2024 13:43
Due to breaking changes within the ACL API, most endpoints had to be reimplemented. This commit introduces the following full implementation: - `acl list` - `acl read` - `acl delete` - `acl clone` `acl create` and `acl update` ared also introduced but currently have limitations since policies and roles aren't properly supported yet.
mbrulatout
requested review from
dclaisse,
pierrecdn,
cpaillet,
mougams and
manu-ns
mbrulatout
changed the title
2 PRs were merged in parallel and broke this test.
Moved and extended the should_skip function + fixed some tests Enable parallel execution which removes the need to cleanup things after a test. Moved the ACL tests in a specific file. Fixtures are now function scoped. This *truly* enables multi-version tests.
mougams
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: remove consul 1.1 and OSX support
code-style: use ruff isort autofix
tests: add test utils for cleaner API output expected assertion
acl: re-implement some basic ACL endpoint
Due to breaking changes within the ACL API, most endpoints
had to be reimplemented.
This commit introduces the following full implementation:
acl listacl readacl deleteacl cloneacl createandacl updateared also introduced butcurrently have limitations since policies and roles aren't
properly supported yet.
tests: fix multi check service registration
Two PRs were merged in parallel and ended up breaking a test
tests: fix tests
This fixes multiversion tests, enables parallel tests and update the consul config file used for testing as well.