Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fio: Adding fio engine #32

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hwbench/bench/benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def __init__(
self.job_number = job_number
self.enginemodule = enginemodule
self.parameters = parameters
self.parameters.benchmark = self
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of unconditional set/get accessors in general, but since you added a set_benchmark, why not use it?


def get_enginemodule(self) -> EngineModuleBase:
return self.enginemodule
Expand Down
6 changes: 6 additions & 0 deletions hwbench/bench/parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ def __init__(
self.skip_method = skip_method
self.sync_start = sync_start

def get_benchmark(self):
return self.benchmark

def set_benchmark(self, benchmark):
self.benchmark = benchmark

def get_pinned_cpu(self):
if self.pinned_cpu == "none":
return ""
Expand Down