Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition for zip upload #110

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix race condition for zip upload #110

wants to merge 3 commits into from

Conversation

j-rf
Copy link

@j-rf j-rf commented Nov 28, 2022

Put operation is not atomic, leading to a race condition when writing a pex file.
Switching to a put to temporary folder and move operation.

j-rf added 2 commits November 28, 2022 17:09
(lint) lint files
f5d0622
[pex upload] race condition safe upload
96c68b4 
- check destination before upload, rm destination if force upload, throw if discrepancy
- use atomic put operation for upload_zip
- if race condition is met, check destination vs source, throw only if there is a discrepancy
@j-rf j-rf requested a review from jcuquemelle November 28, 2022 17:29
@j-rf j-rf requested review from fhoering and mtchib November 29, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcuquemelle jcuquemelle Awaiting requested review from jcuquemelle

@fhoering fhoering Awaiting requested review from fhoering

@mtchib mtchib Awaiting requested review from mtchib

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j-rf