Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for license installation #144

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Add support for license installation #144

merged 1 commit into from
Apr 19, 2024

Conversation

jeremy-clerc
Copy link
Contributor

@jeremy-clerc jeremy-clerc commented Apr 8, 2024

Via system property path so we do not require a restart on
new install or upgrade as the license will be directly loaded.
cf: https://help.sonatype.com/en/installing-and-updating-licenses.html#installing-or-updating-a-license-using-a-system-property

But also via the API directly for when the license needs
to be updated as the system property path does not care
about the license file being updated if a license is
already installed.

@jeremy-clerc
Copy link
Contributor Author

Actually need to use a resource as once installed using license path is not enough to update the license.

@jeremy-clerc jeremy-clerc force-pushed the license branch 10 times, most recently from c191144 to 19e4c94 Compare April 17, 2024 15:49
@jeremy-clerc jeremy-clerc requested a review from Annih April 17, 2024 15:58
resources/default.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@Annih Annih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we use too many notifications here already and the pattern is more and more complexe.
I have the impression that by installing the license early after the tarball extraction and handling down nexus we should be able to cover all cases without notif

resources/default.rb Outdated Show resolved Hide resolved
resources/default.rb Show resolved Hide resolved
Via system property path so we do not require a restart on
new install or upgrade as the license will be directly loaded.
cf: https://help.sonatype.com/en/installing-and-updating-licenses.html#installing-or-updating-a-license-using-a-system-property

But also via the API directly for when the license needs
to be updated as the system property path does not care
about the license file being updated if a license is
already installed.
@jeremy-clerc jeremy-clerc merged commit 8309bff into master Apr 19, 2024
5 checks passed
@jeremy-clerc jeremy-clerc deleted the license branch April 19, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants