Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection list issue #402

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Fix connection list issue #402

merged 2 commits into from
Nov 1, 2023

Conversation

16-karan
Copy link
Contributor

@16-karan 16-karan commented Nov 1, 2023 •
edited
Loading

WHAT

  • Handled Error for connection list
  • Handled Error for verification popup

HOW

  • Added organisation id check
  • Added few tailwind styles

WHY

  • Optimise the code
  • For the optimal user experience

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@16-karan 16-karan self-assigned this Nov 1, 2023
@16-karan 16-karan added the bug Something isn't working label Nov 1, 2023
nishad-ayanworks
nishad-ayanworks approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nishad-ayanworks nishad-ayanworks merged commit 3e9c106 into develop Nov 1, 2023
4 checks passed
@16-karan 16-karan deleted the fix-connection-issue branch November 3, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishad-ayanworks nishad-ayanworks nishad-ayanworks approved these changes

Assignees

@16-karan 16-karan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@16-karan @nishad-ayanworks