Feat: endorsement list and request endorsement for schema #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and flag, created custom function for ecosystem role check Signed-off-by: sanjay-k1910 <[email protected]>
…-endorsement Signed-off-by: sanjay-k1910 <[email protected]>
Signed-off-by: MoulikaKulkarni <[email protected]>
Signed-off-by: MoulikaKulkarni <[email protected]>
Signed-off-by: MoulikaKulkarni <[email protected]>
Signed-off-by: MoulikaKulkarni <[email protected]>
… custom component Signed-off-by: sanjay-k1910 <[email protected]>
…into ecosystem-endorsement-popups Signed-off-by: sanjay-k1910 <[email protected]>
feat: Ecosystem endorsement popups
…ed and updated sidebar code Signed-off-by: sanjay-k1910 <[email protected]>
…-endorsement Signed-off-by: sanjay-k1910 <[email protected]>
Signed-off-by: sanjay-k1910 <[email protected]>
Signed-off-by: sanjay-k1910 <[email protected]>
Signed-off-by: sanjay-k1910 <[email protected]>
…-endorsement Signed-off-by: sanjay-k1910 <[email protected]>
Signed-off-by: sanjay-k1910 <[email protected]>
Signed-off-by: sanjay-k1910 <[email protected]>
…-endorsement Signed-off-by: sanjay-k1910 <[email protected]>
Signed-off-by: sanjay-k1910 <[email protected]>
Signed-off-by: sanjay-k1910 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
| isProcessing: boolean | ||
| } | ||
|
|
||
| const ConfirmModal = (props: IProps) => { |
There was a problem hiding this comment.
Can you please be specific for the model name
There was a problem hiding this comment.
This is a custom confirmation popup and we can use it anywhere in our code.
Can you please suggest a better name?
| // const handleFilter = (e: React.ChangeEvent<HTMLSelectElement>) => { | ||
| // console.log("Handle filter", e.target.value) | ||
| // if (e.target.value === 'All schemas') { | ||
| // setAllSchemaFlag(true) |
There was a problem hiding this comment.
Is this code needed for other development
There was a problem hiding this comment.
Yes, as we discussed, the Schema list does not require any filter for now as we are showing all the schemas created under ecosystems. So, for now, we can keep this code as it is. I'll remove this code in my next PR after discussion.
nishad-ayanworks
suggested changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?