Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor public profile #307

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Refactor public profile #307

merged 6 commits into from
Oct 3, 2023

Conversation

16-karan
Copy link
Contributor

@16-karan 16-karan commented Oct 2, 2023

WHAT

  • Refactored public profile
  • Restrict the user access to create schema without creating wallet
  • Handle the cred def and schema id display on view and verify popup in verification flow
  • Replaced the attribute name to display name in attributes list for verification
  • Replaced organisation description to description in error handling
  • Handle the wallet label length as per standard length

@16-karan 16-karan self-assigned this Oct 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bhavanakarwade bhavanakarwade merged commit 36b8f10 into develop Oct 3, 2023
4 checks passed
@bhavanakarwade bhavanakarwade deleted the refactor-public-profile branch October 3, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavanakarwade bhavanakarwade bhavanakarwade approved these changes

@nishad-ayanworks nishad-ayanworks Awaiting requested review from nishad-ayanworks

Assignees

@16-karan 16-karan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@16-karan @bhavanakarwade