Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardized API's #265

Merged
merged 23 commits into from
Sep 20, 2023
Merged

Standardized API's #265

merged 23 commits into from
Sep 20, 2023

Conversation

bhavanakarwade
Copy link
Contributor

@bhavanakarwade bhavanakarwade commented Sep 14, 2023 •
edited
Loading

What

  • Refactored the API endpoints in the User, Organization, Auth and Agent modules.
  • Improved code Organization and readability.
  • Updated API documentation.

Why

  • To provide better support for future feature development.
  • To make the API more user-friendly and intuitive for developers.

How

  • Reviewed the existing Codebase in the User, Organization, Auth and Agent modules.
  • Refactored the API endpoints using best practices and design patterns.
  • Updated API documentation to reflect the changes made.
  • Ran tests to ensure that the refactored code functions correctly.

@bhavanakarwade bhavanakarwade added the enhancement New feature or request label Sep 14, 2023
@bhavanakarwade bhavanakarwade self-assigned this Sep 14, 2023
@bhavanakarwade
resolved sonar cloud checks
03483bd 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
resolved sonar cloud checks
ddd129b 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
resolved sonar lint checks
5a390d8 
Signed-off-by: bhavanakarwade <[email protected]>
nishad-ayanworks
nishad-ayanworks reviewed Sep 14, 2023
View reviewed changes
src/api/Auth.ts Outdated Show resolved Hide resolved
nishad-ayanworks
nishad-ayanworks reviewed Sep 14, 2023
View reviewed changes
src/api/Fido.ts Outdated Show resolved Hide resolved
nishad-ayanworks
nishad-ayanworks suggested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comments

@bhavanakarwade
Copy link
Contributor Author

Please resolve the comments

Resolved

@16-karan
review changes
02f1983 
Signed-off-by: karan <[email protected]>
@16-karan
review changes
4c4e555 
Signed-off-by: karan <[email protected]>
@16-karan
modifications
088b2af 
Signed-off-by: karan <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

nishad-ayanworks
nishad-ayanworks approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nishad-ayanworks nishad-ayanworks merged commit 326076a into develop Sep 20, 2023
4 checks passed
@nishad-ayanworks nishad-ayanworks deleted the api-standardization branch December 6, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishad-ayanworks nishad-ayanworks nishad-ayanworks approved these changes

@tipusinghaw tipusinghaw Awaiting requested review from tipusinghaw

Assignees

@bhavanakarwade bhavanakarwade

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhavanakarwade @nishad-ayanworks @16-karan