Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : Added support for different email service provider. #746

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat : Added support for different email service provider. #746

wants to merge 2 commits into from

Conversation

ganeshawle25
Copy link
Contributor

What

  • Added support for different email provider like Amazon SES, SMTP(for gmail) and refactored existing SendGrid functionality.

Why

  • As per client's requirement provide email support for Amazon SES and SMTP providers.

How

  • Added 'email.service.ts' class, which contains common 'sendEmail' as entry function and according to EMAIL_PROVIDER property it will call respective functionalities.
  • Added new 'sendWithSES' and 'sendWithSMTP functions for each email provider.
  • Refactored existing sendWithSendGrid function.

tipusinghaw
tipusinghaw reviewed Jun 3, 2024
View reviewed changes
libs/common/src/aws-ses-helper-file.ts Outdated Show resolved Hide resolved
libs/common/src/aws-ses-helper-file.ts Outdated Show resolved Hide resolved
libs/common/src/email.service.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tipusinghaw tipusinghaw self-requested a review July 5, 2024 08:05
@GHkrishna GHkrishna added the feature This is a new feature label Sep 4, 2024
@bhavanakarwade bhavanakarwade deleted the branch develop October 23, 2024 08:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw approved these changes

@shitrerohit shitrerohit Awaiting requested review from shitrerohit

@KulkarniShashank KulkarniShashank Awaiting requested review from KulkarniShashank

@pallavighule pallavighule Awaiting requested review from pallavighule

Assignees

@ganeshawle25 ganeshawle25

Labels
feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganeshawle25 @tipusinghaw @GHkrishna @bhavanakarwade