feat: Add support to select multiple connections while sending proof request #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: pranalidhanavade <[email protected]>
pranalidhanavade
changed the title
tipusinghaw
approved these changes
Dec 5, 2024
Signed-off-by: pranalidhanavade <[email protected]>
GHkrishna
requested changes
Dec 7, 2024
Signed-off-by: pranalidhanavade <[email protected]>
GHkrishna
requested changes
Dec 12, 2024
| @@ -627,16 +648,15 @@ export class VerificationService { | |||
| p_value: parseInt(attribute.value), | |||
| restrictions: [ | |||
| { | |||
| cred_def_id: proofRequestpayload.attributes[index].credDefId ? proofRequestpayload.attributes[index].credDefId : undefined, | |||
| schema_id: proofRequestpayload.attributes[index].schemaId | |||
| cred_def_id: proofRequestpayload?.proofFormats?.indy?.attributes[index].credDefId ? proofRequestpayload?.proofFormats?.indy?.attributes[index].credDefId : undefined, | |||
There was a problem hiding this comment.
in case the attributes[index].credDefId: undefined, does the proofrequest allow any credDef or does the credDef only needs to be undefined?
There was a problem hiding this comment.
No it doesn't allow credDef in this case attributes[index].credDefId: undefined.
Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: pranalidhanavade <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What