Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: socketdock implementation #26

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: socketdock implementation #26

wants to merge 19 commits into from

Conversation

pallavighule
Copy link

What

  • Added socket id manager
  • Added socketdock transport session
  • Added connect disconnect and message routes for accepting socketdock requests

@pallavighule pallavighule self-assigned this Dec 3, 2024
@pallavighule
chore:install dependancies
5e3ead1 
Signed-off-by: pallavicoder <[email protected]>
@pallavighule
fix:format the file
537deaf 
Signed-off-by: pallavicoder <[email protected]>
@pallavighule
fix:deleted setting.json
1a33da3 
Signed-off-by: pallavicoder <[email protected]>
sairanjit
sairanjit requested changes Dec 3, 2024
View reviewed changes
src/constants.ts Outdated Show resolved Hide resolved
src/transport/ProcessInboundMessage.ts Outdated Show resolved Hide resolved
src/transport/SocketIdManager.ts Outdated Show resolved Hide resolved
src/transport/SocketDockInboundTransport.ts Show resolved Hide resolved
src/agent.ts Show resolved Hide resolved
@pallavighule
fix:resolved comments
40cac71 
Signed-off-by: pallavicoder <[email protected]>
@pallavighule
fix:resolved comments
fc3b2d8 
Signed-off-by: pallavicoder <[email protected]>
@pallavighule
fix:resolved comments
85c8c6b 
Signed-off-by: pallavicoder <[email protected]>
sairanjit
sairanjit requested changes Dec 4, 2024
View reviewed changes
src/transport/SocketDockInboundTransport.ts Outdated Show resolved Hide resolved
src/transport/SocketDockInboundTransport.ts Outdated Show resolved Hide resolved
src/transport/SocketDockInboundTransport.ts Outdated Show resolved Hide resolved
pallavighule and others added 6 commits December 4, 2024 16:57
@pallavighule
fix:resolved comments
8b221d1 
Signed-off-by: pallavicoder <[email protected]>
@pallavighule
fix:add some checks
650b6e2 
Signed-off-by: pallavicoder <[email protected]>
@pallavighule
fix:add some checks
d8eba9d 
Signed-off-by: pallavicoder <[email protected]>
@pallavighule
fix:add event listeners
063ac8e 
Signed-off-by: pallavicoder <[email protected]>
@pallavighule
made skipLibCheck true
becbc31 
Signed-off-by: pallavicoder <[email protected]>
@RinkalBhojani
removed transport session if socket is disconnected
64ab6a6 
Signed-off-by: Rinkal Bhojani <[email protected]>
@RinkalBhojani RinkalBhojani force-pushed the feat/socketdock-implementation branch from e509b2a to 64ab6a6 Compare December 17, 2024 11:12
@RinkalBhojani
resolved prettier issue
d7db235 
Signed-off-by: Rinkal Bhojani <[email protected]>
sairanjit
sairanjit requested changes Dec 18, 2024
View reviewed changes
src/agent.ts Outdated Show resolved Hide resolved
src/transport/SocketDockInboundTransport.ts Outdated Show resolved Hide resolved
@pallavighule
chore:changed debug message
c28cf55 
Signed-off-by: pallavicoder <[email protected]>
sairanjit
sairanjit approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@sairanjit sairanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sairanjit sairanjit sairanjit approved these changes

Assignees

@pallavighule pallavighule

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pallavighule @sairanjit @RinkalBhojani