refactor: configure the agent modules and wallet storage #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: replace rpc url Signed-off-by: tipusinghaw <[email protected]> * fix: format issue Signed-off-by: tipusinghaw <[email protected]> * fix: contract address issue Signed-off-by: tipusinghaw <[email protected]> * fix: undefine polygon module changes Signed-off-by: tipusinghaw <[email protected]> * fix: format issue Signed-off-by: tipusinghaw <[email protected]> --------- Signed-off-by: tipusinghaw <[email protected]>
* fix:add OutOfBandRecordId Signed-off-by: pallavicoder <[email protected]> * fix:add OutOfBandRecordId Signed-off-by: pallavicoder <[email protected]> * fix:added recipient key Signed-off-by: pallavicoder <[email protected]> * feat:added recipientKey Signed-off-by: pallavicoder <[email protected]> --------- Signed-off-by: pallavicoder <[email protected]>
* Create DMP_2024.yml Signed-off-by: Ajay Jadhav <[email protected]> * Update and rename DMP_2024.yml to DMP_2024.yml Signed-off-by: Sai Ranjit Tummalapalli <[email protected]> --------- Signed-off-by: Ajay Jadhav <[email protected]> Signed-off-by: Sai Ranjit Tummalapalli <[email protected]> Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
* feat: upgrade credo to 0.5.0 Signed-off-by: Sai Ranjit Tummalapalli <[email protected]> * refactor: remove unused modules Signed-off-by: Sai Ranjit Tummalapalli <[email protected]> * fix: dependencies Signed-off-by: Sai Ranjit Tummalapalli <[email protected]> * fix: auto update flags Signed-off-by: Sai Ranjit Tummalapalli <[email protected]> * fix: docker file Signed-off-by: Sai Ranjit Tummalapalli <[email protected]> * fix:W3C schema Signed-off-by: tipusinghaw <[email protected]> --------- Signed-off-by: Sai Ranjit Tummalapalli <[email protected]> Signed-off-by: tipusinghaw <[email protected]> Co-authored-by: tipusinghaw <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| export const RPC_URL = 'https://rpc-mumbai.maticvigil.com' | ||
| export const FILE_SERVER_TOKEN = | ||
| 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJBeWFuV29ya3MiLCJpZCI6ImNhZDI3ZjhjLTMyNWYtNDRmZC04ZmZkLWExNGNhZTY3NTMyMSJ9.I3IR7abjWbfStnxzn1BhxhV0OEzt1x3mULjDdUcgWHk' | ||
| export const RPC_URL = 'https://polygon-mumbai.infura.io/v3/0579d305568d404e996e49695e9272a3' |
Check failure
Code scanning / SonarCloud
Infura API keys should not be disclosed
…nto refactor/credo-controller
sairanjit
requested changes
Apr 3, 2024
src/cliAgent.ts
Outdated
Comment on lines
378
to
380
| autoAcceptCredentials || '', | ||
| autoAcceptProofs || '', | ||
| walletScheme || '' |
There was a problem hiding this comment.
Can these values be empty if not passed ?
src/cliAgent.ts
Outdated
Comment on lines
366
to
368
| autoAcceptCredentials || '', | ||
| autoAcceptProofs || '', | ||
| walletScheme || '' |
There was a problem hiding this comment.
Can these values be empty if not passed ?
There was a problem hiding this comment.
After adding an enum as a type, we should ensure that the default values passed align with the values defined in the enum.
added 2 commits
April 4, 2024 15:33
Signed-off-by: KulkarniShashank <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
added 2 commits
April 5, 2024 13:05
Signed-off-by: KulkarniShashank <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
sairanjit
requested changes
Apr 7, 2024
package.json
Outdated
| @@ -58,6 +58,7 @@ | |||
| "cors": "^2.8.5", | |||
| "express": "^4.18.1", | |||
| "express-rate-limit": "^7.1.5", | |||
| "joi": "^17.12.2", | |||
There was a problem hiding this comment.
Are we using this package ?
Signed-off-by: Krishna <[email protected]>
Signed-off-by: Krishna <[email protected]>
feat: added messageType on the credo core
…into fix/agent-auth
fix: agent auth
Signed-off-by: KulkarniShashank <[email protected]>
fix: specify Node.js version 18.19.0 in engines
Signed-off-by: KulkarniShashank <[email protected]>
fix: specify Node.js version 18.19.0 in yml file
…nto refactor/credo-controller Signed-off-by: KulkarniShashank <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactor the configuration setup for agent modules, wallet storage, and network management within the credo-controller.
Why
The current configuration setup lacks clarity and modularity, making it difficult to maintain and extend the system. By restructuring the configuration for agent modules, wallet storage, and network management, aim to improve readability, maintainability, and scalability of the codebase.
How
Agent Modules Configuration
Separate configuration files for each agent module to isolate configurations and enhance modularity.
Implement a centralized configuration handler to manage agent module configurations efficiently.
Wallet Storage Configuration
Introduce a dedicated configuration file for wallet storage settings.
Configuration file for specifying wallet storage paths, credentials, and other relevant parameters.
Network Management Configuration
Abstract network management settings into a separate configuration module.
Integrate support for dynamic network configuration changes through configuration files or API endpoints.