Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: separate function createwallet createdid #61

Closed
wants to merge 16 commits into from
Closed

feat: separate function createwallet createdid #61

wants to merge 16 commits into from

Conversation

bhavanakarwade
Copy link
Contributor

What?

  • Split create wallet and create DID functions
  • Refactored indy, web and key method functions
  • Implemented DID create API for dedicated agent
  • Implemented DID create API for multi-tenant agent

Why?

  • Splitting the wallet creation and DID creation functions allows for better organization and separation of concerns within the codebase

@bhavanakarwade
feat: implement create did api
7a5b34f 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
fix: resolved conflicts
87db586 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade bhavanakarwade self-assigned this Feb 22, 2024
@bhavanakarwade bhavanakarwade added the enhancement New feature or request label Feb 22, 2024
@bhavanakarwade
resolved sonar lint checks
1697648 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
Merge branch 'main' of https://github.com/credebl/afj-controller into…
deac089 
… feat/separate-function-createwallet-createdid
@bhavanakarwade
resolved sonarcloud checks
fd73ae0 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
resolved sonar lint checks
43e904e 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
added routes and swagger json file
3e94097 
Signed-off-by: bhavanakarwade <[email protected]>
tipusinghaw
tipusinghaw reviewed Feb 22, 2024
View reviewed changes
src/controllers/did/DidController.ts
const didMethod = `did:indy:${data.method}`
let result
switch (createDidOptions.method) {
case DidMethod.Indy:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can check the supported key type before calling the specific handler function. just a thought

src/controllers/did/DidController.ts Outdated Show resolved Hide resolved
src/controllers/did/DidController.ts Outdated Show resolved Hide resolved
src/controllers/did/DidController.ts Outdated Show resolved Hide resolved
src/controllers/did/DidController.ts Outdated Show resolved Hide resolved
@bhavanakarwade
fix: resolved comments
b6cae9a 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
Merge branch 'main' of https://github.com/credebl/afj-controller into…
3424d6c 
… feat/separate-function-createwallet-createdid
@bhavanakarwade
feat: implement get all dids api
22ba72a 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
Merge branch 'main' of https://github.com/credebl/afj-controller into…
b5655d7 
… feat/separate-function-createwallet-createdid
@bhavanakarwade
Merge branch 'main' of https://github.com/credebl/afj-controller into…
0629ee9 
… feat/separate-function-createwallet-createdid
@bhavanakarwade
removed extra options
d5af67c 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
removed extra options
60a9886 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
refactored create did interface
a06bb07 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
removed unnecessary code
1f5314a 
Signed-off-by: bhavanakarwade <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tipusinghaw tipusinghaw deleted the feat/separate-function-createwallet-createdid branch March 27, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw left review comments

@sairanjit sairanjit Awaiting requested review from sairanjit

@ankita-p17 ankita-p17 Awaiting requested review from ankita-p17

@KulkarniShashank KulkarniShashank Awaiting requested review from KulkarniShashank

@vivekayanworks vivekayanworks Awaiting requested review from vivekayanworks

Assignees

@bhavanakarwade bhavanakarwade

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhavanakarwade @tipusinghaw