Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Error Handling and Logging in DeviantArt Data Fetching Script #134

Closed
wants to merge 1 commit into from

Conversation

shivam8112005
Copy link

Fixes

Description

This pull request improves logging and error handling in the data retrieval script by adding detailed messages to enhance debugging and track execution progress in deviantart_fetched

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shivam8112005 shivam8112005 requested review from a team as code owners October 12, 2024 12:04
@shivam8112005 shivam8112005 requested review from TimidRobot and Shafiya-Heena and removed request for a team October 12, 2024 12:04
@shivam8112005
Copy link
Author

hey @TimidRobot can you please review this pr .

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have concerns with this pull request:

  • This script isn't currently in use--why are these particular errors being handled? We don't want to add handling of errors that are never really encountered.
  • Many of the added try blocks simply log an error and continue instead of raising an exceptions.
  • These changes significantly increase the verbosity of the script. I suspect that some of the logger messages should be debug instead of info (but the script doesn't currently support setting a verbosity level)

Recommendations for moving this work forward:

  • document errors encountered and only add handling for those errors
  • write a new issue that proposes what data should be error, info, and debug

@shivam8112005
Copy link
Author

ohhk got it

@TimidRobot TimidRobot self-assigned this Nov 19, 2024
@TimidRobot TimidRobot added the ⛔️ status: discarded Will not be worked on label Nov 19, 2024
@TimidRobot TimidRobot closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔️ status: discarded Will not be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants