Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have provided pagination for the case table #242

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

webbunivAdmin
Copy link

@webbunivAdmin webbunivAdmin commented Oct 19, 2024

Fixes

Description

  • This pull request resolves the issue of the case table being overcrowded with large datasets. It implements a dynamic and interactive table that supports pagination, search functionality, and sorting. This allows users to navigate large amounts of data without cluttering the page.

Technical details

  • Added pagination to break large datasets into manageable pages.
  • Implemented search functionality to help users filter data.
  • Enabled sorting of table columns for better data organization.

Tests

Screenshots

Screenshot 2024-10-19 213606

Screenshot 2024-10-19 213723

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@webbunivAdmin webbunivAdmin requested review from a team as code owners October 19, 2024 18:58
@webbunivAdmin webbunivAdmin requested review from TimidRobot, Shafiya-Heena and krysal and removed request for a team October 19, 2024 18:58
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure this pull request (PR) branch (ewebbunivAdmin:Dan-Dev) is up-to-date with the main branch of creativecommons/legaldb.

Please update so that filters are maintained when you navigate to different pages.

legal_db/templates/legal_db/case/index.html Outdated Show resolved Hide resolved
legal_db/templates/legal_db/case/index.html Outdated Show resolved Hide resolved
@TimidRobot TimidRobot self-assigned this Oct 22, 2024
@webbunivAdmin
Copy link
Author

@TimidRobot I think have updated on how you recommended

@Vanessa082
Copy link
Contributor

@webbunivAdmin nice job you have there please could you include the name of the issue author also I suggest you work on the table styling to most especially when it comes to the years table row the table head should align with the table data. also, to better test how the table is going to look I prefer you use the Creative Commons license names so you know how the fields are going to look like. Also, work on the responsiveness of the table because I remember when working on the card case it was not responsive
@TimidRobot Please am I on track

@TimidRobot
Copy link
Member

Please update so that filters are maintained when you navigate to different pages.

This is still an issue, but I'm not sure how it can be resolved until there's data to test with:

@TimidRobot
Copy link
Member

The repository now has development data. Please load it and confirm that pagination works correctly with filters.

@webbunivAdmin
Copy link
Author

legal
after adding the dev data

@TimidRobot
Copy link
Member

TimidRobot commented Nov 26, 2024

Tests ✅

Command:

./bin/test.sh 

Output:

# Django collectstatic                                                  08:20:28 

1 static file copied to '/legaldb/staticfiles', 480 unmodified, 516 post-processed.

# Django test                                                           08:20:30 
Found 13 test(s).
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
2024-11-26 16:20:33 [38] [WARNING] pathname=/usr/local/lib/python3.12/site-packages/django/utils/log.py lineno=241 funcname=log_response Not Found: /en/cases/1/
.......2024-11-26 16:20:34 [38] [WARNING] pathname=/usr/local/lib/python3.12/site-packages/django/utils/log.py lineno=241 funcname=log_response Not Found: /en/scholarship/1/
......
----------------------------------------------------------------------
Ran 13 tests in 2.260s

OK
Destroying test database for alias 'default'...

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every page action (changing tags, keyword, or page) needs to maintain all of the state parameters:

  • direction=
  • keywords=
  • page=
  • sort=
  • tags[]=

@TimidRobot
Copy link
Member

@webbunivAdmin the main branch now has the Debug Toolbar installed (for development environments). You might find it easier to develop/troubleshoot after you merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Improve on the case table
3 participants