Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the inconsistency in footer with vocabulary design system #828

Conversation

Dev-JoyA
Copy link
Contributor

@Dev-JoyA Dev-JoyA commented Oct 10, 2024

Fixes

Description

This PR addresses inconsistencies in the footer of the website, aligning it with the current Vocabulary design system.

Changes Made:

Updated social media icons to match the design system's specifications.

  • Adjusted the logo size for consistency with the Vocabulary guidelines.
  • Increased the size of the "Donate Now" button to align with the design system.
  • Replaced the text above the "Donate Now" button to match Vocabulary's version.
  • Modified the width of the newsletter form to ensure visual consistency with the design system.

These changes enhance the overall user experience by ensuring uniformity across the website.

##Technical Details
creativecommons/vocabulary: A cohesive system of design for Creative Commons

Screenshots

Before
Screenshot 2024-10-10 at 12 09 50

Now
Screenshot 2024-10-10 at 12 09 18

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Dev-JoyA Dev-JoyA requested review from a team as code owners October 10, 2024 11:11
@Dev-JoyA Dev-JoyA requested review from TimidRobot, Shafiya-Heena and dhruvkb and removed request for a team October 10, 2024 11:11
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update / resolve conflicts since Vocabulary was added in:

@Dev-JoyA
Copy link
Contributor Author

Please update / resolve conflicts since Vocabulary was added in:

@TimidRobot conflicts resolved

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you duplicated assets/static/vocabulary/css/vocabulary.css, doubling it's length, instead of resolving conflicts. For example:

  1. /*
    Style rules are written with two sections
    at current, separated by an empty line.
  2. /*
    Style rules are written with two sections
    at current, separated by an empty line.

@Dev-JoyA Dev-JoyA force-pushed the feature/fixes-footer-incosistency-with-design-system branch from 11b6b81 to 3cb9676 Compare October 22, 2024 09:04
@Dev-JoyA
Copy link
Contributor Author

It looks like you duplicated assets/static/vocabulary/css/vocabulary.css, doubling it's length, instead of resolving conflicts. For example:

  1. /*
    Style rules are written with two sections
    at current, separated by an empty line.
  2. /*
    Style rules are written with two sections
    at current, separated by an empty line.

@TimidRobot I sincerely apologies for this , it has been resolved

@TimidRobot TimidRobot self-assigned this Oct 24, 2024
@TimidRobot TimidRobot added the 🚧 status: blocked Blocked & therefore, not ready for work label Oct 24, 2024
@TimidRobot

This comment was marked as outdated.

@TimidRobot TimidRobot removed the 🚧 status: blocked Blocked & therefore, not ready for work label Nov 5, 2024
@TimidRobot TimidRobot changed the base branch from main to vocab-refresh November 5, 2024 15:22
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work!!

(target branch changed to vocab-refresh as the various page parts are interdependent)

@Dev-JoyA
Copy link
Contributor Author

Dev-JoyA commented Nov 5, 2024

Thank you for this work!!

(target branch changed to vocab-refresh as the various page parts are interdependent)

@TimidRobot Thank you for your kind words and for reviewing my work! I really appreciate your patience, help, and the corrections you provided.

@TimidRobot TimidRobot merged commit 29a5ff7 into creativecommons:vocab-refresh Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature] Footer does not match the current Vocabulary design system
2 participants