-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the inconsistency in footer with vocabulary design system #828
Fixed the inconsistency in footer with vocabulary design system #828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update / resolve conflicts since Vocabulary was added in:
@TimidRobot conflicts resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you duplicated assets/static/vocabulary/css/vocabulary.css
, doubling it's length, instead of resolving conflicts. For example:
creativecommons.github.io-source/assets/static/vocabulary/css/vocabulary.css
Lines 1 to 4 in 30ba9f3
/* Style rules are written with two sections at current, separated by an empty line. creativecommons.github.io-source/assets/static/vocabulary/css/vocabulary.css
Lines 2061 to 2064 in 30ba9f3
/* Style rules are written with two sections at current, separated by an empty line.
11b6b81
to
3cb9676
Compare
@TimidRobot I sincerely apologies for this , it has been resolved |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work!!
(target branch changed to vocab-refresh as the various page parts are interdependent)
@TimidRobot Thank you for your kind words and for reviewing my work! I really appreciate your patience, help, and the corrections you provided. |
Fixes
Description
This PR addresses inconsistencies in the footer of the website, aligning it with the current Vocabulary design system.
Changes Made:
Updated social media icons to match the design system's specifications.
These changes enhance the overall user experience by ensuring uniformity across the website.
##Technical Details
creativecommons/vocabulary: A cohesive system of design for Creative Commons
Screenshots
Before
Now
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin