Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure links do not downgrade security or break continuity (use path-only or https://) #65

Open
6 tasks
mzeinstra opened this issue Nov 9, 2020 · 4 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🔒 staff only Restricted to CC staff members 🏁 status: ready for work Ready for work

Comments

@mzeinstra
Copy link

Problem

CC should want to protect its users when possible, HTTPS is a means to do that. Even though the website that links to already redirect http to https, it is good stewardship.

Description

Some links in the repo refer to external websites using http, this needs to change to https where possible.

Alternatives

We could also make these links protocol agnostic.

Implementation

  • create branch
  • Search repo on 'http://'
  • replace with 'https://' , after check if external site has https
  • create Pull request
  • ????
  • profit

@TimidRobot indicated that they wanted to leave links to / within RDF alone. Could you elaborate @TimidRobot?

@mzeinstra mzeinstra added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Nov 9, 2020
@Enigma04
Copy link

is this still an issue? if so, I'd be happy to work on it.

@TimidRobot TimidRobot changed the title Ensure that HTTPS is used where possible. Ensure links do not downgrade security or break continuity (use https://, //, or path) Dec 8, 2021
@TimidRobot
Copy link
Member

TimidRobot commented Dec 8, 2021

HTML

In order from greatest breadth / strongest preference to most specific / least preference:

  1. path-only (/, no protocol nor domain)
    • any URLs that are not informative (that are not displayed to users) should be path-only.
    • This will allow the site to be served from other locations (ex. for development, for staging, on GitHub Pages) without compromising functionality
  2. TLS/SSL (https://)
    • any creativecommons.org links that informative should use https://creativecommons.org instead of http://creativecommons.org (links without a protocol should remain that way, ex. creativecommons.org)
    • any links to other websites should be evaluated for TLS/SSL support and use https:// wherever possible
    • CC Canonical URLs and HTML Canonical Links
  3. protocol agnostic (//)
    • Better to use TLS/SSL or resolve any environment issues that require HTTP
  4. insecure (http://)
    • Bad (not good)

RDF (XML)

@TimidRobot TimidRobot changed the title Ensure links do not downgrade security or break continuity (use https://, //, or path) Ensure links do not downgrade security or break continuity (use path-only or https://) Dec 8, 2021
@TimidRobot
Copy link
Member

is this still an issue? if so, I'd be happy to work on it.

I will work on this as it involves updating the translations and requires access to Transifex.

@TimidRobot TimidRobot self-assigned this Dec 8, 2021
@TimidRobot TimidRobot added 🏁 status: ready for work Ready for work 💻 aspect: code Concerns the software code in the repository 📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon and removed 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Dec 8, 2021
@TimidRobot TimidRobot added the 🔒 staff only Restricted to CC staff members label Sep 21, 2023
@TimidRobot
Copy link
Member

TimidRobot commented Sep 21, 2023

The only non-RDF http:// that I see remaining are:

templates/includes/notice_deprecated.html
5-  {{ tool.deprecated_on|date:'Y-m-d' }}: {% blocktrans trimmed %}
6-    Creative Commons has
7:    <a href="http://creativecommons.org/retiredlicenses">retired this legal
templates/includes/deed_body_licenses.html
70:      {% blocktrans %}You must give <a href="#" id="appropriate_credit_popup" class="helpLink">appropriate credit</a></span>, provide a link to the license, and <span rel="cc:requires" resource="http://creativecommons.org/ns#Notice"><a href="#" id="indicate_changes_popup" class="helpLink">indicate if changes were made</a></span>. You may do so in any reasonable manner, but not in any way that suggests the licensor endorses you or your use.{% endblocktrans %}

Both of these occurrences appear in translated strings. This means that updating them requires updating all relevent translations in both the repository and on Transifex (marking this issue 🔒 staff only)

@TimidRobot TimidRobot moved this to In review in Applications Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🔒 staff only Restricted to CC staff members 🏁 status: ready for work Ready for work
Projects
Status: Backlog
Development

No branches or pull requests

3 participants