Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] improve HTML Canonical Link behavior #241

Closed
TimidRobot opened this issue Dec 21, 2021 · 0 comments · Fixed by #260
Closed

[Bug] improve HTML Canonical Link behavior #241

TimidRobot opened this issue Dec 21, 2021 · 0 comments · Fixed by #260
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be fixed ASAP 🏁 status: ready for work Ready for work

Comments

@TimidRobot
Copy link
Member

TimidRobot commented Dec 21, 2021

Description

Simplistic HTML Canonical Link support was added in #237. However it wrongly always uses the legal tool's Legacy Canonical URL.

Examples

Label URL
Legacy Canonical URL: https://creativecommons.org/licenses/by/4.0/
HTML Canonical Link: https://creativecommons.org/licenses/by/4.0/deed.en
Legacy Canonical URL: https://creativecommons.org/publicdomain/zero/1.0/
HTML Canonical Link: https://creativecommons.org/publicdomain/zero/1.0/deed.en

Expectation

The HTML Canonical Link should point to appropriate language-specific Deed or Legal Code page without the .html extension.

Page Examples

  • HTML Canonical Link: https://creativecommons.org/licenses/by/4.0/deed.en

    • /licenses/by/4.0/ (Legacy Canonical URL, HTTP server configured to use default index page: index.html)
    • /licenses/by/4.0/deed (HTTP server configured to serve content without .html file extension)
    • /licenses/by/4.0/deed.html (symlink to default language: deed.en.html)
    • /licenses/by/4.0/deed.en (HTTP server configured to serve content without .html file extension)
    • /licenses/by/4.0/deed.en.html
    • /licenses/by/4.0/index.html (symlink to default language: deed.en.html)
  • HTML Canonical Link: https://creativecommons.org/licenses/by/4.0/deed.nl

    • /licenses/by/4.0/deed.nl (HTTP server configured to serve content without .html file extension)
    • /licenses/by/4.0/deed.nl.html
  • HTML Canonical Link: https://creativecommons.org/licenses/by/4.0/legalcode.en

    • /licenses/by/4.0/legalcode (HTTP server configured to serve content without .html file extension)
    • */licenses/by/4.0/legalcode.html (symlink to default language: legalcode.en.html)
    • /licenses/by/4.0/legalcode.en (HTTP server configured to serve content without .html file extension)
    • /licenses/by/4.0/legalcode.en.html
  • HTML Canonical Link: https://creativecommons.org/licenses/by/4.0/legalcode.nl

    • /licenses/by/4.0/legalcode.nl (HTTP server configured to serve content without .html file extension)
    • /licenses/by/4.0/legalcode.nl.html

HTML Example

  • HTML Canonical Link: https://creativecommons.org/licenses/by/4.0/deed.en
    <link href="https://creativecommons.org/licenses/by/4.0/deed.en" rel="canonical"/>

Change Approval

Dropping the shorter English-favoring Legacy Canonical URL in favor of the HTML Canonical Link was discussed with and approved by the CC Legal Team.

Additional context

@TimidRobot TimidRobot added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Dec 21, 2021
@TimidRobot TimidRobot self-assigned this Dec 21, 2021
@TimidRobot TimidRobot added 🟥 priority: critical Must be fixed ASAP and removed 🟧 priority: high Stalls work on the project or its dependents labels Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be fixed ASAP 🏁 status: ready for work Ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant