-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQL Scheduler docs #59
Conversation
Found one issue when I was going to link the header "SQL Scheduler". The consequence of this fix is that the header written this way can't be linked to. I will look for alternative, that should stop progress of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file still weighs in with +507 KB. Is it legit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From looking at other screenshots they're about average, no? Not sure I can do much more.
docs/_assets/img/cluster-sql-console.png from GH-66 is also pretty large, but I also can't get it smaller, even after reducing its physical width.
So, I figure it will be good to go. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thought I was doing something wrong for a sec. But they are somewhat big, it's weird.
I will look into it a bit more. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+326 KB for that one. Acceptable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used oxipng on all of them 🤷🏻♂️
From looking at other screenshots they're about average, no? Not sure I can do much more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wonder why that one is much larger than the others.
What's Inside
Documentation for the new feature "SQL Job Scheduler"
Preview
https://crate-cloud--59.org.readthedocs.build/en/59/reference/overview.html#failed-cloning
(just below. why i'm linking to this explained below)
Highlights
Introduction of the feature
UI navigation to/around the feature. Explanation on the "Overview" and "Logs" tabs.
Examples
Limitations and possible issues
PR also contains few unrelated link fixes, leftovers from cloud-docs rst->md conversion #55 that were not caught before. Also deletion ofsign-up.rst
, it complained about bunch of stuff and we don't need it anymore so deletion was easier.Checklist