Code cleanup #57
Merged
Code cleanup #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just fixed #45 as well |
|
This looks great, thanks for this! |
kevaundray
pushed a commit
that referenced
this pull request
Dec 23, 2022
* Code cleanup (#57) Co-authored-by: ControlC ControlV <[email protected]> * More Code Cleanup (#59) * Add in Verkle Proof Benchmark (#60) * fixed some unsafe unwraps * fixed some unsafe unwraps * some progress? * fixes * nits * mostly cleanup * clippy * yml fix * wtf is yml * sorry Co-authored-by: ControlC ControlV <[email protected]>
kevaundray
pushed a commit
that referenced
this pull request
Jan 9, 2023
* Controlc/fixed everything (#1) * Code cleanup (#57) Co-authored-by: ControlC ControlV <[email protected]> * More Code Cleanup (#59) * Add in Verkle Proof Benchmark (#60) * fixed some unsafe unwraps * fixed some unsafe unwraps * some progress? * fixes * nits * mostly cleanup * clippy * yml fix * wtf is yml * sorry * verkle-trie refactors * Error Refactoring Done????: * Clippy working now Co-authored-by: ControlC ControlV <[email protected]> * fix * addressed comments Co-authored-by: ControlC ControlV <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squash and merge ofc, I did some cleanup
Fixed ~40 clippy errors, would have done more but started running into things like unused variables which were being used, so didn't want to touch those parts until I am more familiar with the repo.
Deleted .DS_Store files from MacOS, and added them to the
.gitignore, they don't do anything but can be a bit messycargo fmt --all