-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring: split theme.lua
into separate groups.
#51
base: main
Are you sure you want to change the base?
Conversation
Thank you for the work I was meaning to do this myself once i had some time. |
If possible I would like to split the different themes into files, like it is tokyonight. And don't use the colour inversion function inside the |
We'll have to wait for @craftzdog to approve cause this is a huge change and see if that's something he thinks should be considered. |
You're right. I have implemented theme switching using the invert function. If @craftzdog decides to split themes according tokyonight, another PR can be opened in the future. |
Hi, thanks for the work! Here is the reference: https://ethanschoonover.com/solarized/ I'm happy to review this PR. Could you resolve the conflicts? |
Thanks for the opportunity to work on this PR. It was one of my first big PRs. If I did anything wrong please post it. I tried to do my best, but there may be some mistakes, as I'm just learning how to work with Git and open source projects. I would really like to work on another PR after the holidays. I would like to separate the Kinds that are used in |
Hi, thanks for the plugin. I refactored it, but I don't know how to do the switching between dark and light themes. I'll have a look at how to do that. Sorry for open and close previous PR, I split one commit into more smaller commits.
Fixes #48.