Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating luxon and json5 dependencies and fixing broken tests. #40

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Updating luxon and json5 dependencies and fixing broken tests. #40

merged 1 commit into from
Apr 11, 2023

Conversation

dwwinters
Copy link

No description provided.

@dwwinters
Copy link
Author

@cmoesel and @mgramigna: Hoping to get a review from one or both of you. This supersedes PRs #38 and #39.

mgramigna
mgramigna approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@mgramigna mgramigna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I tested with all my repos that use cql-exec-fhir and everything works the same as it did before. I had one question about the json5 resolution that doesn't necessarily require action. More just a curiosity.

package.json Show resolved Hide resolved
@dwwinters dwwinters merged commit b66a288 into master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgramigna mgramigna mgramigna approved these changes

@cmoesel cmoesel Awaiting requested review from cmoesel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwwinters @mgramigna