Fix stored relation prefix_join on key range #286
+136
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zh217 @creatorrr would love a review. Change itself is very small and tests are copied from @creatorrr new-rocksdb work over to the old cozorocks implementation. |
* The stored relation (both with and without validity) was incorrectly using non-key values when seeking for the start key in a range resulting in the first key that should've been returned being skipped.
* For example, in the case of a stored relation defined as `*r{k => v}`, a query for `*r{k, v}, k >= 3` would skip over a key with value 3 because it will do a join with the key encoding of [3, null] where null is for the value of v.
* In the prefix join, only the keys should be considered, not the value columns so truncate the bindings to the length of the keys to exclude values.
keitharobertson
force-pushed
the
fix-stored-prefix-join
branch
from
b42d0c7
to
ff9a4fc
Compare
|
Lgtm! |
|
Did the main tests also pass? @keitharobertson |
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*r{k => v}, a query for*r{k, v}, k >= 3would skip over a key with value 3 because it will do a join with the key encoding of [3, null] where null is for the value of v.