Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modeldetails): adding properties for supporting case classification #902

Merged
merged 1 commit into from
Jan 8, 2025
Merged

feat(modeldetails): adding properties for supporting case classification #902

merged 1 commit into from
Jan 8, 2025
+31 −0

Conversation

lprovost-coveo
Copy link
Contributor

@lprovost-coveo lprovost-coveo commented Jan 7, 2025 •
edited
Loading

Acceptance Criteria

Sourced my changes from the API here's the PR where the properties were changed https://github.com/coveo-platform/ml-config-service/pull/2449

These properties are not documented, we're not documenting them.

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@lprovost-coveo lprovost-coveo requested review from a team as code owners January 7, 2025 19:38
@lprovost-coveo lprovost-coveo force-pushed the feat/MLX-1849-add-properties branch from 24fec9d to ff1f8ff Compare January 7, 2025 19:41
@lprovost-coveo lprovost-coveo added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit 47cf59c Jan 8, 2025
11 checks passed
@lprovost-coveo lprovost-coveo deleted the feat/MLX-1849-add-properties branch January 8, 2025 19:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

🎉 This PR is included in version 57.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdostie gdostie gdostie approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@FelixBlaisThon FelixBlaisThon Awaiting requested review from FelixBlaisThon FelixBlaisThon is a code owner automatically assigned from coveo/frontend-foundation

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

@JTangCoveo JTangCoveo Awaiting requested review from JTangCoveo

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lprovost-coveo @louis-bompart @gdostie