Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modeldetails): migrate type to record #900

Merged
merged 1 commit into from
Jan 6, 2025
Merged

feat(modeldetails): migrate type to record #900

merged 1 commit into from
Jan 6, 2025

Conversation

lprovost-coveo
Copy link
Contributor

@lprovost-coveo lprovost-coveo commented Dec 27, 2024 •
edited
Loading

Change type from Map to Record.
Should be able to migrate without issue.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@lprovost-coveo lprovost-coveo requested review from a team as code owners December 27, 2024 15:52
@lprovost-coveo lprovost-coveo added this pull request to the merge queue Jan 6, 2025
Merged via the queue into master with commit 7e39c36 Jan 6, 2025
11 checks passed
@lprovost-coveo lprovost-coveo deleted the feat/MLX-1807-type-migration branch January 6, 2025 16:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

🎉 This PR is included in version 57.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@gdostie gdostie gdostie approved these changes

@GermainBergeron GermainBergeron Awaiting requested review from GermainBergeron

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lprovost-coveo @gdostie @alexprudhomme