feat: remove version number in get objecttype call (#822)

* feat: remove version number in get objecttype call * fix: change naming
coveo · May 23, 2024 · 3b5e628 · 3b5e628
1 parent 238d542
commit 3b5e628
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 25 deletions.
diff --git a/src/resources/Catalogs/CatalogContent.ts b/src/resources/Catalogs/CatalogContent.ts
@@ -6,21 +6,11 @@ export type ObjectType = {
     objectType: string;
 };
 
-export type Version = {
-    version: number;
-};
-
 export default class CatalogContent extends Resource {
     static baseUrl = `/rest/organizations/${API.orgPlaceholder}/catalogcontent/source`;
 
-    getObjectTypeV2(sourceId: string, version: Version) {
-        return this.api.get<CatalogObjectType>(
-            this.buildPath(`${CatalogContent.baseUrl}/${sourceId}/objecttypes`, version),
-        );
-    }
-
     getObjectTypes(sourceId: string) {
-        return this.api.get<string[]>(`${CatalogContent.baseUrl}/${sourceId}/objecttypes`);
+        return this.api.get<CatalogObjectType>(`${CatalogContent.baseUrl}/${sourceId}/objecttypes`);
     }
 
     getMetadataValues(sourceId: string, objectType: ObjectType) {

diff --git a/src/resources/Catalogs/tests/CatalogContent.spec.ts b/src/resources/Catalogs/tests/CatalogContent.spec.ts
@@ -18,20 +18,6 @@ describe('CatalogContent', () => {
         metadata = new CatalogContent(api, serverlessApi);
     });
 
-    describe('getObjectTypeV2', () => {
-        it('should make a GET call to the specific CatalogContent url', () => {
-            const defaultOptions: queryString.StringifyOptions = {skipEmptyString: true, skipNull: true, sort: false};
-            const sourceId = 'McDonald';
-            const version = {version: 2};
-
-            metadata.getObjectTypeV2(sourceId, version);
-            expect(api.get).toHaveBeenCalledTimes(1);
-            expect(api.get).toHaveBeenCalledWith(
-                `${baseUrl}/${sourceId}/objecttypes?${queryString.stringify(version, {...defaultOptions})}`,
-            );
-        });
-    });
-
     describe('getObjectTypes', () => {
         it('should make a GET call to the specific CatalogContent url', () => {
             const sourceId = 'McDonald';