Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): support apikey for ui:deploy #1455

Merged
merged 1 commit into from
Apr 2, 2024
Merged

feat(cli): support apikey for ui:deploy #1455

merged 1 commit into from
Apr 2, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Mar 26, 2024 •
edited
Loading

Proposed changes

  • Allow users to authenticate using API key to deploy their pages.

Testing

  • Unit Tests: existing tests was testing for failure.
  • Functionnal Tests:

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your contribution @louis-bompart !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions GitHub Actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@louis-bompart louis-bompart marked this pull request as ready for review March 28, 2024 14:49
@louis-bompart louis-bompart requested a review from a team as a code owner March 28, 2024 14:49
@louis-bompart louis-bompart requested review from olamothe, y-lakhdar and fbeaudoincoveo and removed request for a team March 28, 2024 14:49
@louis-bompart louis-bompart merged commit d296470 into master Apr 2, 2024
50 checks passed
@louis-bompart louis-bompart deleted the api-key branch April 2, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamothe olamothe olamothe approved these changes

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-bompart @olamothe