fix(snapshot): define resourceToPreview from resources changed. #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
olamothe,
y-lakhdar and
fbeaudoincoveo
and removed request for
a team
|
Thanks for your contribution @louis-bompart !
|
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
olamothe
approved these changes
Mar 14, 2024
Co-authored-by: Olivier Lamothe <[email protected]>
louis-bompart
added a commit
that referenced
this pull request
Mar 18, 2024
<!-- For Coveo Employees only. Fill this section. CDX-1534 --> ## Proposed changes #1453 , I didn't test the suggestion, and it was breaking the code. Iterating from the OG code + suggestions, here's a nice solution. ## Testing: - Reproduced reported issue w/ master and latest release - Did not with this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The current algorithm doesn't take into account the resources the user can access.
To solves that, we could either:
Breaking changes
Testing
Snapshot UTs are tangled, changing it will be difficult/require a rewrite.
Corner-case, would require to create orgs without some access right or some stuff like that.
In the only known affected environment (customer-owned), I managed to reproduce the issue the same customer reported.
https://coveord.atlassian.net/browse/CDX-1530