chore(tests): try to fix failing e2e tests by increasing beforeAll timeout #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeaudoincoveo
requested review from
y-lakhdar and
louis-bompart
and removed request for
a team
|
Thanks for your contribution @fbeaudoincoveo !
|
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
|
I think it works in the end? Should we close @fbeaudoincoveo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There are a couple of e2e tests in the atomic spec that keep failing at the same spot, namely in the
beforeAllatwhen using an existing pageId (--pageId flag specified)>when the project is configured correctly.I’ve already verified that running the same command locally against the stg org / pageId used in the test works, so that should not be the issue.
The test fails with a timeout, so maybe increasing it will solve the issue.