Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency octokit to v3 [security] j:cdx-227 - autoclosed #1407

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 15, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
octokit 2.0.14 -> 3.1.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-50728

Impact

Versions v9.26.0, v10.9.x), v11.1.x, v12.0.x all contained the code that would throw the error.

Specifically, during a pentest we encountered a bug in the octokit/webhooks library (a dependency of Probot, a framework for building Github Apps). The resulting request was found to cause an uncaught exception that ends the nodejs process.

The problem is caused by an issue with error handling in the @​octokit/webhooks library because the error can be undefined in some cases.

Credit goes to @​pb82 (for the early analysis) and @​rh-tguittet (for discovery).

Patches

Maintenance releases for the Error being thrown by the verify method in octokit/webhooks.js

Maintenance release for the reference for octokit/webhooks.js in app.js

Maintenance release for the reference for octokit/webhooks.js in octokit.js

Maintenance release for the reference for octokit/webhooks.js in Protobot

Workarounds

It is recommend that all users upgrade to the latest version of octokit/webhooks.js or use one of the updated back ported versions.


Release Notes

octokit/octokit.js (octokit)

v3.1.2

Compare Source

Bug Fixes
  • updates app.js for the handling of an error being thrown by the verify method in webhooks.js (#​2576) (b59da80)

v3.1.1

Compare Source

Bug Fixes

v3.1.0

Compare Source

Features

v3.0.0

Compare Source

Features
BREAKING CHANGES
  • Drop support for NodeJS v14, v16
  • Remove previews support for the REST API
  • remove agent option from octokit.request()
  • Replace support for Node.js http(s) Agents with documentation on using fetch dispatchers instead (via @octokit/request)
  • Remove ability to pass custom request options, except for method, headers, body, signal (via @​octokit/request)

v2.1.0

Compare Source

Features

v2.0.22

Compare Source

Bug Fixes

v2.0.21

Compare Source

Bug Fixes

v2.0.20

Compare Source

Bug Fixes

v2.0.19

Compare Source

Bug Fixes

v2.0.18

Compare Source

Bug Fixes

v2.0.17

Compare Source

Bug Fixes

v2.0.16

Compare Source

Bug Fixes

v2.0.15

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner January 15, 2024 22:41
@renovate renovate bot requested review from y-lakhdar and removed request for a team January 15, 2024 22:41
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jan 15, 2024
Copy link
Contributor

Thanks for your contribution @renovate[bot] !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@renovate renovate bot force-pushed the renovate/npm-octokit-vulnerability branch from 5f92218 to f5fb814 Compare January 30, 2024 14:47
@renovate renovate bot changed the title fix(deps): update dependency octokit to v3 [security] j:cdx-227 fix(deps): update dependency octokit to v3 [security] j:cdx-227 - autoclosed Jan 31, 2024
@renovate renovate bot closed this Jan 31, 2024
@renovate renovate bot deleted the renovate/npm-octokit-vulnerability branch January 31, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants