Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ignore when no snaps changed #1358

Merged
merged 1 commit into from
Oct 26, 2023
Merged

chore: ignore when no snaps changed #1358

merged 1 commit into from
Oct 26, 2023

Conversation

louis-bompart
Copy link
Collaborator

Proposed changes

Breaking changes

Testing

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:

@louis-bompart louis-bompart requested a review from a team as a code owner October 26, 2023 21:13
@louis-bompart louis-bompart requested review from olamothe, y-lakhdar and mrrajamanickam-coveo and removed request for a team October 26, 2023 21:13
@louis-bompart louis-bompart changed the title ignore when no snaps changed chore: ignore when no snaps changed Oct 26, 2023
@github-actions
Copy link
Contributor

Thanks for your contribution @louis-bompart !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@louis-bompart louis-bompart merged commit 489f134 into master Oct 26, 2023
14 of 16 checks passed
@louis-bompart louis-bompart deleted the ignore-empty-snaps branch October 26, 2023 21:14
@github-actions
Copy link
Contributor

Pull Request Title is not semantic:

✏️ input: ignore when no snaps changed
❌ subject may not be empty [subject-empty]
❌ type may not be empty [type-empty]

❌ found 2 problems, 0 warnings
ℹ️ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-lakhdar y-lakhdar y-lakhdar approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@mrrajamanickam-coveo mrrajamanickam-coveo Awaiting requested review from mrrajamanickam-coveo mrrajamanickam-coveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-bompart @y-lakhdar