Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add organization to event props #1325

Merged
merged 2 commits into from
Oct 10, 2023
Merged

feat: add organization to event props #1325

merged 2 commits into from
Oct 10, 2023

Conversation

y-lakhdar
Copy link
Contributor

https://coveord.atlassian.net/browse/CDX-1480

Proposed changes

Add organization id to event properties in Amplitude.

Testing

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:

@y-lakhdar y-lakhdar requested a review from a team as a code owner September 21, 2023 14:48
@y-lakhdar y-lakhdar requested review from louis-bompart, dmbrooke and mrrajamanickam-coveo and removed request for a team September 21, 2023 14:48
@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 5c436ef.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Manifest Files

@github-actions
Copy link
Contributor

Thanks for your contribution @y-lakhdar !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@y-lakhdar y-lakhdar enabled auto-merge (squash) September 28, 2023 18:29
@y-lakhdar y-lakhdar merged commit 3afcd0f into master Oct 10, 2023
32 checks passed
@y-lakhdar y-lakhdar deleted the CDX-1480 branch October 10, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrrajamanickam-coveo mrrajamanickam-coveo mrrajamanickam-coveo approved these changes

@dmbrooke dmbrooke dmbrooke approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@y-lakhdar @louis-bompart @dmbrooke @mrrajamanickam-coveo