chore: pin ci env to ubuntu 20.04 (#1043)

https://coveord.atlassian.net/browse/CDX-1241  ## Proposed changes For now 🧊 we'll figure out a fix later. actions/runner-images#6399
coveo · Nov 24, 2022 · e41dba4 · e41dba4
1 parent d4ec642
commit e41dba4
Show file tree

Hide file tree

Showing 20 changed files with 39 additions and 38 deletions.
diff --git a/.github/actions/e2e-run/action.yml b/.github/actions/e2e-run/action.yml
@@ -23,7 +23,7 @@ runs:
   steps:
     - name: Setup runner
       shell: bash
-      if: ${{inputs.os == 'ubuntu-latest'}}
+      if: ${{inputs.os == 'ubuntu-20.04'}}
       # Ensure we can use as many file watcher as we want. see https://github.com/facebook/create-react-app/blob/master/docusaurus/docs/troubleshooting.md#npm-start-fail-due-to-watch-error
       run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
     - name: Setup runner
@@ -51,7 +51,7 @@ runs:
       shell: bash
     - name: End-to-end Setup
       shell: bash
-      if: ${{inputs.os == 'ubuntu-latest'}}
+      if: ${{inputs.os == 'ubuntu-20.04'}}
       run: bash packages/cli-e2e/entrypoints/ci.sh
     - name: End-to-end Setup
       shell: powershell
@@ -66,7 +66,7 @@ runs:
         npm_config_registry: ${{inputs.npmRegistry}}
     - name: Tests
       shell: bash
-      if: ${{inputs.os == 'ubuntu-latest'}}
+      if: ${{inputs.os == 'ubuntu-20.04'}}
       env:
         DISPLAY: ':1'
         npm_config_registry: ${{inputs.npmRegistry}}

diff --git a/.github/workflows/build-binaries.yml b/.github/workflows/build-binaries.yml
@@ -26,7 +26,7 @@ jobs:
           - os: windows-latest
             pack-command: ' win'
             for: 'windows install kit'
-          - os: ubuntu-latest
+          - os: ubuntu-20.04
             pack-command: ' deb'
             for: 'linux install kit'
 
@@ -47,7 +47,7 @@ jobs:
         run: ../../../node_modules/oclif/bin/run pack${{ matrix.pack-command }}
       - name: Create packages
         working-directory: ./packages/cli/core
-        if: ${{matrix.os == 'ubuntu-latest'}}
+        if: ${{matrix.os == 'ubuntu-20.04'}}
         run: ../../../node_modules/oclif/bin/run pack tarballs
       - name: Get commit hash of binaries
         run: node ../../../scripts/get-commit-short-hash.mjs

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -20,10 +20,10 @@ env:
 jobs:
   lint:
     name: Lint
-    runs-on: 'ubuntu-latest'
+    runs-on: 'ubuntu-20.04'
     steps:
       - name: Setup runner
-        if: ${{matrix.os == 'ubuntu-latest'}}
+        if: ${{matrix.os == 'ubuntu-20.04'}}
         # Ensure we can use as many file watcher as we want. see https://github.com/facebook/create-react-app/blob/master/docusaurus/docs/troubleshooting.md#npm-start-fail-due-to-watch-error
         run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
       - name: Setup runner
@@ -46,10 +46,10 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        os: ['ubuntu-latest', 'windows-latest']
+        os: ['ubuntu-20.04', 'windows-latest']
     steps:
       - name: Setup runner
-        if: ${{matrix.os == 'ubuntu-latest'}}
+        if: ${{matrix.os == 'ubuntu-20.04'}}
         # Ensure we can use as many file watcher as we want. see https://github.com/facebook/create-react-app/blob/master/docusaurus/docs/troubleshooting.md#npm-start-fail-due-to-watch-error
         run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
       - name: Setup runner
@@ -71,7 +71,7 @@ jobs:
   e2e-setup-login:
     timeout-minutes: 15
     name: End-to-end login
-    runs-on: 'ubuntu-latest'
+    runs-on: 'ubuntu-20.04'
     outputs:
       cliConfigJson: ${{ steps.setup.outputs.cliConfigJson}}
     env:
@@ -88,7 +88,7 @@ jobs:
   e2e-setup-verdaccio:
     strategy:
       matrix:
-        os: ['ubuntu-latest', 'windows-latest']
+        os: ['ubuntu-20.04', 'windows-latest']
     name: End-to-end publish packages
     runs-on: ${{matrix.os}}
     steps:
@@ -106,7 +106,7 @@ jobs:
           cache: 'npm'
           node-version-file: '.nvmrc'
       - uses: actions/cache@9b0c1fce7a93df8e3bb8926b0d6e9d89e92f20a7 # v3
-        if: ${{matrix.os == 'ubuntu-latest'}}
+        if: ${{matrix.os == 'ubuntu-20.04'}}
         with:
           path: packages/cli-e2e/verdaccio
           key: verdaccio-${{matrix.os}}-${{ github.sha }}-${{ github.run_attempt }}
@@ -132,7 +132,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: ['ubuntu-latest', 'windows-latest']
+        os: ['ubuntu-20.04', 'windows-latest']
         spec:
           [
             'angular.specs.ts',
@@ -155,7 +155,7 @@ jobs:
     steps:
       - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3
       - uses: actions/cache@9b0c1fce7a93df8e3bb8926b0d6e9d89e92f20a7 # v3
-        if: ${{matrix.os == 'ubuntu-latest'}}
+        if: ${{matrix.os == 'ubuntu-20.04'}}
         with:
           path: packages/cli-e2e/verdaccio
           key: verdaccio-${{matrix.os}}-${{ github.sha }}-${{ github.run_attempt }}
@@ -178,7 +178,7 @@ jobs:
     name: End-to-end teardown
     if: ${{ always() }}
     needs: [e2e, e2e-setup-login]
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     env:
       # ID of the test run to identify resources to teardown.
       TEST_RUN_ID: '${{ github.sha }}-${{ github.run_attempt }}g'
@@ -192,7 +192,7 @@ jobs:
     name: End-to-end status reporter
     if: ${{ always() }}
     needs: e2e
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - name: Check e2e matrix status
         if: ${{ needs.e2e.result != 'success' }}
@@ -202,7 +202,7 @@ jobs:
     name: Pre-release
     if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }}
     needs: [e2e-report, lint, unit-tests]
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     environment: prerelease
     steps:
       - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3

diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
@@ -23,7 +23,7 @@ on:
 jobs:
   analyze:
     name: Analyze
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     permissions:
       actions: read
       contents: read

diff --git a/.github/workflows/daily-e2e.yml b/.github/workflows/daily-e2e.yml
@@ -24,7 +24,7 @@ env:
 jobs:
   e2e-setup-login:
     name: End-to-end login
-    runs-on: 'ubuntu-latest'
+    runs-on: 'ubuntu-20.04'
     timeout-minutes: 30
     outputs:
       cliConfigJson: ${{ steps.setup.outputs.cliConfigJson}}
@@ -54,7 +54,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: ['ubuntu-latest', 'windows-latest']
+        os: ['ubuntu-20.04', 'windows-latest']
         node: [18]
         spec:
           [
@@ -93,7 +93,7 @@ jobs:
     name: End-to-end teardown
     if: ${{ always() }}
     needs: [e2e, e2e-setup-login]
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     env:
       # ID of the test run to identify resources to teardown.
       TEST_RUN_ID: '${{ github.sha }}-${{ github.run_attempt }}-dailyg'
@@ -115,7 +115,7 @@ jobs:
     timeout-minutes: 30
     if: ${{ always() }}
     needs: e2e
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     environment: Daily Tests
     steps:
       - name: Check e2e matrix status

diff --git a/.github/workflows/delete-resources.yml b/.github/workflows/delete-resources.yml
@@ -8,7 +8,7 @@ on:
 
 jobs:
   delete-resources:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     environment: Cleaning
     env:
       ORG_ID: ${{ secrets.ORG_ID }}

diff --git a/.github/workflows/merge-bot.yml b/.github/workflows/merge-bot.yml
@@ -9,7 +9,7 @@ on:
 jobs:
   Merge:
     if: ${{ github.event_name == 'pull_request' || github.event.issue.pull_request }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     env:
       GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
     steps:

diff --git a/.github/workflows/package-lock-root-fail.yml b/.github/workflows/package-lock-root-fail.yml
@@ -16,6 +16,6 @@ on:
 
 jobs:
   lockfile-outside-of-root:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - run: exit 1
diff --git a/.github/workflows/package-lock-root-success.yml b/.github/workflows/package-lock-root-success.yml
@@ -14,6 +14,6 @@ on:
 
 jobs:
   lockfile-outside-of-root:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - run: exit 0
diff --git a/.github/workflows/package-lock-version-fail.yml b/.github/workflows/package-lock-version-fail.yml
@@ -12,7 +12,7 @@ on:
 
 jobs:
   lockfile-version:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3
       - name: Check lockfileVersion of all package-lock.json

diff --git a/.github/workflows/package-lock-version-succes.yml b/.github/workflows/package-lock-version-succes.yml
@@ -12,6 +12,6 @@ on:
 
 jobs:
   lockfile-version:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - run: exit 0
diff --git a/.github/workflows/pr-title-semantic-lint.yml b/.github/workflows/pr-title-semantic-lint.yml
@@ -5,7 +5,7 @@ on:
     types: [opened, edited, synchronize, reopened]
 jobs:
   Lint:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     env:
       GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
     steps:

diff --git a/.github/workflows/prbot.yml b/.github/workflows/prbot.yml
@@ -4,7 +4,7 @@ on:
 
 jobs:
   run-script:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     env:
       GITHUB_CREDENTIALS: ${{ secrets.GITHUB_TOKEN }}
     steps:

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -14,7 +14,7 @@ on:
 
 jobs:
   snyk:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     env:
       SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
       NODE_OPTIONS: --max-old-space-size=8192
@@ -47,7 +47,7 @@ jobs:
   release:
     needs: snyk
     environment: 'Release'
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     env:
       GITHUB_CREDENTIALS: ${{ secrets.CLI_RELEASE }}
     steps:

diff --git a/.github/workflows/renovate-config-validator.yml b/.github/workflows/renovate-config-validator.yml
@@ -12,7 +12,7 @@ on:
 
 jobs:
   renovate-config:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3
       - uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3

diff --git a/.github/workflows/snyk-master.yml b/.github/workflows/snyk-master.yml
@@ -13,7 +13,7 @@ on:
       - completed
 jobs:
   snyk:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3
       - uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3

diff --git a/packages/cli-e2e/setup/utils/utils.ts b/packages/cli-e2e/setup/utils/utils.ts
@@ -65,7 +65,8 @@ export function createUiProjectDirectory() {
 
 export function setProcessEnv() {
   process.env.TEST_RUN_ID =
-    process.env.TEST_RUN_ID ?? `id${randomBytes(16).toString('hex')}g`;
+    process.env.TEST_RUN_ID?.replaceAll(/\./g, '-') ??
+    `id${randomBytes(16).toString('hex')}g`;
   process.env.PLATFORM_ENV = process.env.PLATFORM_ENV?.toLowerCase() || '';
   process.env.PLATFORM_HOST = getPlatformHost(process.env.PLATFORM_ENV);
   process.env.NX_DAEMON = 'false';

diff --git a/packages/cli-e2e/tsconfig.json b/packages/cli-e2e/tsconfig.json
@@ -8,7 +8,7 @@
     "sourceMap": true,
     "forceConsistentCasingInFileNames": true,
     "types": ["jest", "node"],
-    "lib": ["dom", "es2017"]
+    "lib": ["dom", "ESNext"]
   },
   "include": ["./**/*.ts"]
 }
diff --git a/scripts/cleaning/delete-api-keys.js b/scripts/cleaning/delete-api-keys.js
@@ -10,7 +10,7 @@ config({path: join(homedir(), '.env')});
 function wasCreatedByTheCli(testRunId = '') {
   return (key) =>
     (key.displayName?.startsWith(`cli-idwindows-latest-${testRunId}`) ||
-      key.displayName?.startsWith(`cli-idubuntu-latest-${testRunId}`) ||
+      key.displayName?.startsWith(`cli-idubuntu-20.04-${testRunId}`) ||
       key.displayName?.startsWith(`cli-id${testRunId}`)) &&
     key.description === 'Generated by the Coveo CLI';
 }

diff --git a/scripts/cleaning/delete-orgs.js b/scripts/cleaning/delete-orgs.js
@@ -16,7 +16,7 @@ function wasCreatedByTheCli(testRunId = '') {
   return (key) =>
     testRunId
       ? key.displayName?.startsWith(`cli-e2e-idwindows-latest-${testRunId}`) ||
-        key.displayName?.startsWith(`cli-e2e-idubuntu-latest-${testRunId}`)
+        key.displayName?.startsWith(`cli-e2e-idubuntu-20.04-${testRunId}`)
       : key.displayName?.match(/cli-e2e.*g/);
 }