Skip to content

Commit

Permalink
fix(node): use node 16, npm 7 and lockfileVersion 2 exclusively (#486)
Browse files Browse the repository at this point in the history
  • Loading branch information
louis-bompart authored Oct 4, 2021
1 parent 7f02939 commit 1c4e0f8
Show file tree
Hide file tree
Showing 30 changed files with 108,910 additions and 15,531 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '14'
node-version: '16'
- name: Setup
run: npm run setup
- name: Get tag
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
fail-fast: true
matrix:
os: ['ubuntu-latest', 'windows-latest']
node: [14]
node: [16]
env:
PLATFORM_USER_NAME: ${{ secrets.PLATFORM_USER_NAME }}
PLATFORM_USER_PASSWORD: ${{ secrets.PLATFORM_USER_PASSWORD }}
Expand Down Expand Up @@ -42,7 +42,7 @@ jobs:
run: npm run test
- name: Build CLI
working-directory: ./packages/cli
run: tsc -p ./tsconfig.json
run: npm run build
- name: End-to-end Tests
if: ${{matrix.os == 'ubuntu-latest'}}
run: bash packages/cli-e2e/entrypoints/ci.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/delete-api-keys.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '14'
node-version: '16'
- run: npm i
- run: node ./scripts/delete-api-keys.js --olderThan 1d
18 changes: 9 additions & 9 deletions .github/workflows/merge-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ on:
types: [opened]

jobs:
Merge:
if: ${{ github.event_name == 'pull_request' || github.event.issue.pull_request }}
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
steps:
- uses: actions/setup-node@v2
- name: Run the Bot
run: npx @coveo/merge-bot
Merge:
if: ${{ github.event_name == 'pull_request' || github.event.issue.pull_request }}
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
steps:
- uses: actions/setup-node@v2
- name: Run the Bot
run: npx @coveo/merge-bot
19 changes: 19 additions & 0 deletions .github/workflows/package-lock-validator.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: 'package-lock.json validator'

on:
push:
branches: [master]
paths:
- '**/package-lock.json'
pull_request:
branches: [master]
paths:
- '**/package-lock.json'

jobs:
lockfile-version:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Check lockfileVersion of all package-lock.json
run: node scripts/check-lockfile-versions.js $(find ./ -xdev -wholename '**/package-lock.json')
20 changes: 10 additions & 10 deletions .github/workflows/pr-title-semantic-lint.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
name: PrTitleSemanticLint
on:
pull_request:
branches: [ master ]
branches: [master]
types: [opened, edited, synchronize, reopened]
jobs:
Lint:
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
steps:
- uses: actions/checkout@v2
- name: Ensure PR Title is Semantic
run: |
npm ci
npx @coveo/is-pr-title-semantic
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
steps:
- uses: actions/checkout@v2
- name: Ensure PR Title is Semantic
run: |
npm ci
npx @coveo/is-pr-title-semantic
2 changes: 1 addition & 1 deletion .github/workflows/prbot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v2
with:
node-version: '14'
node-version: '16'
- run: npm i
- run: npm run pr:report
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- run: git fetch --depth=1 origin +refs/tags/*:refs/tags/* # see https://stackoverflow.com/a/60184319/9285308
- uses: actions/setup-node@v2
with:
node-version: '14'
node-version: '16'
- run: npm run setup
- name: Setup credentials
run: |
Expand Down
Loading

0 comments on commit 1c4e0f8

Please sign in to comment.