Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated release documentation for GSI #245

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

a-atri
Copy link
Collaborator

@a-atri a-atri commented Dec 9, 2024

Jira

  • AV-87721

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Type of Change

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

Testing

Required Checklist:

  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if required)
  • I have run make fmt and formatted my code
  • I have made sure that no schema field is marked with both requiresReplace and computed

Further comments

@a-atri a-atri requested review from a team as code owners December 9, 2024 06:43
Copy link
Contributor

@simon-dew simon-dew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

docs/guides/1.4.0-upgrade-guide.md Outdated Show resolved Hide resolved
docs/guides/1.4.0-upgrade-guide.md Outdated Show resolved Hide resolved
docs/guides/1.4.0-upgrade-guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Rebecca-Martinez007 Rebecca-Martinez007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of suggestions to keep the verbs in present tense.

I wanted to be consistent with the present tense that was in the change log here: https://github.com/couchbasecloud/terraform-provider-couchbase-capella/blob/main/CHANGELOG.md

Let me know if these were intentional and/or my changes causes issues.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
…cs team

Co-authored-by: Rebecca Martinez <[email protected]>
Co-authored-by: Simon Dew <[email protected]>
@simon-dew simon-dew self-requested a review December 10, 2024 12:38
Copy link
Contributor

@simon-dew simon-dew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments addressed, LGTM 👍

Copy link
Contributor

@Rebecca-Martinez007 Rebecca-Martinez007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@a-atri a-atri merged commit 786b5ee into main Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants