-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated release documentation for GSI #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of suggestions to keep the verbs in present tense.
I wanted to be consistent with the present tense that was in the change log here: https://github.com/couchbasecloud/terraform-provider-couchbase-capella/blob/main/CHANGELOG.md
Let me know if these were intentional and/or my changes causes issues.
…cs team Co-authored-by: Rebecca Martinez <[email protected]> Co-authored-by: Simon Dew <[email protected]>
Co-authored-by: Simon Dew <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments addressed, LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Jira
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Type of Change
Manual Testing Approach
How was this change tested and do you have evidence? (REQUIRED: Select at least 1)
Testing
Testing
Required Checklist:
Further comments