Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AV-73526] Add support for rate-limiting retries #157

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

ajsqr
Copy link
Contributor

@ajsqr ajsqr commented Mar 1, 2024

Jira

  • AV-73526

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Type of Change

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

Testing Decreased the rate limit in local-dev manually to 3 and attempted creating 7 API Key resources

Do you want to perform these actions?
Terraform will perform the actions described above.
Only 'yes' will be accepted to approve.

Enter a value: yes

couchbase-capella_apikey.new_apikey5: Creating...
couchbase-capella_apikey.new_apikey2: Creating...
couchbase-capella_apikey.new_apikey1: Creating...
couchbase-capella_apikey.new_apikey4: Creating...
couchbase-capella_apikey.new_apikey6: Creating...
couchbase-capella_apikey.new_apikey3: Creating...
couchbase-capella_apikey.new_apikey: Creating...
couchbase-capella_apikey.new_apikey4: Still creating... [10s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [10s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [10s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [10s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [10s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [10s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [10s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [20s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [20s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [20s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [20s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [20s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [20s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [20s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [30s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [30s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [30s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [30s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [30s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [30s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [30s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [40s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [40s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [40s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [40s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [40s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [40s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [40s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [50s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [50s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [50s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [50s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [50s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [50s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [50s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [1m0s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [1m0s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [1m0s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [1m0s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [1m0s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [1m0s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [1m0s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [1m10s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [1m10s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [1m10s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [1m10s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [1m10s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [1m10s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [1m10s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [1m20s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [1m20s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [1m20s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [1m20s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [1m20s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [1m20s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [1m20s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [1m30s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [1m30s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [1m30s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [1m30s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [1m30s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [1m30s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [1m30s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [1m40s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [1m40s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [1m40s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [1m40s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [1m40s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [1m40s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [1m40s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [1m50s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [1m50s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [1m50s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [1m50s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [1m50s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [1m50s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [1m50s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [2m0s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [2m0s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [2m0s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [2m0s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [2m0s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [2m0s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [2m0s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [2m10s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [2m10s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [2m10s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [2m10s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [2m10s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [2m10s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [2m10s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [2m20s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [2m20s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [2m20s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [2m20s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [2m20s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [2m20s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [2m20s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [2m30s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [2m30s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [2m30s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [2m30s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [2m30s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [2m30s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [2m30s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [2m40s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [2m40s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [2m40s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [2m40s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [2m40s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [2m40s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [2m40s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [2m50s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [2m50s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [2m50s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [2m50s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [2m50s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [2m50s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [2m50s elapsed]
couchbase-capella_apikey.new_apikey4: Still creating... [3m0s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [3m0s elapsed]
couchbase-capella_apikey.new_apikey1: Still creating... [3m0s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [3m0s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [3m0s elapsed]
couchbase-capella_apikey.new_apikey3: Still creating... [3m0s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [3m0s elapsed]
couchbase-capella_apikey.new_apikey3: Creation complete after 3m0s [id=VX8Xr6llnmcTLvMkxAwQMnup5NDPBney]
couchbase-capella_apikey.new_apikey4: Creation complete after 3m0s [id=gZEbv3KMUgzUhyxZ0H5b3dHtD0y1AAtC]
couchbase-capella_apikey.new_apikey1: Creation complete after 3m1s [id=AYYCp3CKFK2PnXZX4Z157g1NFC7VQbnw]
couchbase-capella_apikey.new_apikey6: Still creating... [3m10s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [3m10s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [3m10s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [3m10s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [3m20s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [3m20s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [3m20s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [3m20s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [3m30s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [3m30s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [3m30s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [3m30s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [3m40s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [3m40s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [3m40s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [3m40s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [3m50s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [3m50s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [3m50s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [3m50s elapsed]
couchbase-capella_apikey.new_apikey: Still creating... [4m0s elapsed]
couchbase-capella_apikey.new_apikey5: Still creating... [4m0s elapsed]
couchbase-capella_apikey.new_apikey2: Still creating... [4m0s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [4m0s elapsed]
couchbase-capella_apikey.new_apikey5: Creation complete after 4m1s [id=qiOsKJosajS4nB9Duq7CkomuFD1ODxqW]
couchbase-capella_apikey.new_apikey: Creation complete after 4m1s [id=1wcE9RRDp4aES88PJdxzHZfFhkkZasBN]
couchbase-capella_apikey.new_apikey2: Creation complete after 4m1s [id=9LXaeRdBUC9bDVIq6nY9qIvFBZxxAb7P]
couchbase-capella_apikey.new_apikey6: Still creating... [4m10s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [4m20s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [4m30s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [4m40s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [4m50s elapsed]
couchbase-capella_apikey.new_apikey6: Still creating... [5m0s elapsed]
couchbase-capella_apikey.new_apikey6: Creation complete after 5m1s [id=57uxQVKCu1Dl7UwlTBR2QYTRK8kqYKAg]

Apply complete! Resources: 7 added, 0 changed, 0 destroyed.

=========================================================
Acceptance testing

ajayajith@Ajays-MBP-2 terraform-provider-couchbase-capella % make testacc
TF_ACC=1 go test -timeout=300m -v ./... -run TestAccOrganizationDataSource -run TestAccProjectResource -run TestAccCreateProjectWithReqFields -run TestAccCreateProjectOptFields -run TestAccValidProjectUpdate -run TestAccInvalidProjectResource -run TestAccDeleteProjectBeforeDestroy -run TestAccClusterResourceAzure -run TestAccClusterResourceGCP -run TestAccClusterResourceWithOnlyReqFieldAWS
? github.com/couchbasecloud/terraform-provider-couchbase-capella [no test files]
? github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/api/appservice [no test files]
? github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/api/backup [no test files]
? github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/api/backup_schedule [no test files]
? github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/api/bucket [no test files]
? github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/api/cluster [no test files]
? github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/api/organization [no test files]
testing: warning: no tests to run
PASS
ok github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/api (cached) [no tests to run]
? github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/errors [no test files]
? github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/provider [no test files]
testing: warning: no tests to run
PASS
ok github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/datasources (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/resources (cached) [no tests to run]
? github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/testing [no test files]
? github.com/couchbasecloud/terraform-provider-couchbase-capella/version [no test files]
=== RUN TestAccClusterResourceWithOnlyReqFieldAWS
=== PAUSE TestAccClusterResourceWithOnlyReqFieldAWS
=== CONT TestAccClusterResourceWithOnlyReqFieldAWS
raw state map[%:16 audit.%:5 audit.created_at:2024-03-11 10:45:46.529028332 +0000 UTC audit.created_by:7AsCv7QPGJ6pGQEFIau2P8qlN9OlQ6gz audit.modified_at:2024-03-11 10:48:00.185446764 +0000 UTC audit.modified_by:7AsCv7QPGJ6pGQEFIau2P8qlN9OlQ6gz audit.version:5 availability.%:1 availability.type:multi cloud_provider.%:3 cloud_provider.cidr:10.208.250.0/23 cloud_provider.region:us-east-1 cloud_provider.type:aws configuration_type:multiNode couchbase_server.%:1 couchbase_server.version:7.2 current_state:healthy description: etag:Version: 5 id:abb708ed-d5cb-479c-9194-296ff5934eb4 name:acc_cluster_eugrmdysjc organization_id:7a99d00c-f55b-4b39-bc72-1b4cc68ba894 project_id:e14f20e3-42fb-4cb1-9928-2ac7826ffd48 service_groups.#:1 service_groups.0.%:3 service_groups.0.node.%:2 service_groups.0.node.compute.%:2 service_groups.0.node.compute.cpu:4 service_groups.0.node.compute.ram:16 service_groups.0.node.disk.%:4 service_groups.0.node.disk.iops:3000 service_groups.0.node.disk.storage:50 service_groups.0.node.disk.type:io2 service_groups.0.num_of_nodes:3 service_groups.0.services.#:3 service_groups.0.services.0:data service_groups.0.services.1:index service_groups.0.services.2:query support.%:2 support.plan:developer pro support.timezone:PT]raw state map[%:16 audit.%:5 audit.created_at:2024-03-11 10:45:46.529028332 +0000 UTC audit.created_by:7AsCv7QPGJ6pGQEFIau2P8qlN9OlQ6gz audit.modified_at:2024-03-11 10:48:00.185446764 +0000 UTC audit.modified_by:7AsCv7QPGJ6pGQEFIau2P8qlN9OlQ6gz audit.version:5 availability.%:1 availability.type:multi cloud_provider.%:3 cloud_provider.cidr:10.208.250.0/23 cloud_provider.region:us-east-1 cloud_provider.type:aws configuration_type:multiNode couchbase_server.%:1 couchbase_server.version:7.2 current_state:healthy description: etag:Version: 5 id:abb708ed-d5cb-479c-9194-296ff5934eb4 name:acc_cluster_eugrmdysjc organization_id:7a99d00c-f55b-4b39-bc72-1b4cc68ba894 project_id:e14f20e3-42fb-4cb1-9928-2ac7826ffd48 service_groups.#:1 service_groups.0.%:3 service_groups.0.node.%:2 service_groups.0.node.compute.%:2 service_groups.0.node.compute.cpu:4 service_groups.0.node.compute.ram:16 service_groups.0.node.disk.%:4 service_groups.0.node.disk.iops:3000 service_groups.0.node.disk.storage:50 service_groups.0.node.disk.type:io2 service_groups.0.num_of_nodes:3 service_groups.0.services.#:3 service_groups.0.services.0:data service_groups.0.services.1:index service_groups.0.services.2:query support.%:2 support.plan:developer pro support.timezone:PT]raw state map[%:16 audit.%:5 audit.created_at:2024-03-11 10:45:46.529028332 +0000 UTC audit.created_by:7AsCv7QPGJ6pGQEFIau2P8qlN9OlQ6gz audit.modified_at:2024-03-11 10:54:44.183857839 +0000 UTC audit.modified_by:7AsCv7QPGJ6pGQEFIau2P8qlN9OlQ6gz audit.version:11 availability.%:1 availability.type:multi cloud_provider.%:3 cloud_provider.cidr:10.208.250.0/23 cloud_provider.region:us-east-1 cloud_provider.type:aws configuration_type:multiNode couchbase_server.%:1 couchbase_server.version:7.2 current_state:healthy description:Cluster Updated. etag:Version: 11 id:abb708ed-d5cb-479c-9194-296ff5934eb4 if_match:5 name:Terraform Acceptance Test Cluster Update organization_id:7a99d00c-f55b-4b39-bc72-1b4cc68ba894 project_id:e14f20e3-42fb-4cb1-9928-2ac7826ffd48 service_groups.#:2 service_groups.0.%:3 service_groups.0.node.%:2 service_groups.0.node.compute.%:2 service_groups.0.node.compute.cpu:4 service_groups.0.node.compute.ram:16 service_groups.0.node.disk.%:4 service_groups.0.node.disk.iops:3001 service_groups.0.node.disk.storage:51 service_groups.0.node.disk.type:gp3 service_groups.0.num_of_nodes:3 service_groups.0.services.#:1 service_groups.0.services.0:data service_groups.1.%:3 service_groups.1.node.%:2 service_groups.1.node.compute.%:2 service_groups.1.node.compute.cpu:8 service_groups.1.node.compute.ram:32 service_groups.1.node.disk.%:4 service_groups.1.node.disk.iops:3001 service_groups.1.node.disk.storage:51 service_groups.1.node.disk.type:gp3 service_groups.1.num_of_nodes:2 service_groups.1.services.#:2 service_groups.1.services.0:index service_groups.1.services.1:query support.%:2 support.plan:enterprise support.timezone:IST]raw state map[%:16 audit.%:5 audit.created_at:2024-03-11 10:45:46.529028332 +0000 UTC audit.created_by:7AsCv7QPGJ6pGQEFIau2P8qlN9OlQ6gz audit.modified_at:2024-03-11 10:54:57.850897684 +0000 UTC audit.modified_by:7AsCv7QPGJ6pGQEFIau2P8qlN9OlQ6gz audit.version:16 availability.%:1 availability.type:multi cloud_provider.%:3 cloud_provider.cidr:10.208.250.0/23 cloud_provider.region:us-east-1 cloud_provider.type:aws configuration_type:multiNode couchbase_server.%:1 couchbase_server.version:7.2 current_state:healthy description:Cluster Updated. etag:Version: 16 id:abb708ed-d5cb-479c-9194-296ff5934eb4 name:Terraform Acceptance Test Cluster Update 2 organization_id:7a99d00c-f55b-4b39-bc72-1b4cc68ba894 project_id:e14f20e3-42fb-4cb1-9928-2ac7826ffd48 service_groups.#:2 service_groups.0.%:3 service_groups.0.node.%:2 service_groups.0.node.compute.%:2 service_groups.0.node.compute.cpu:4 service_groups.0.node.compute.ram:16 service_groups.0.node.disk.%:4 service_groups.0.node.disk.iops:3001 service_groups.0.node.disk.storage:51 service_groups.0.node.disk.type:gp3 service_groups.0.num_of_nodes:3 service_groups.0.services.#:1 service_groups.0.services.0:data service_groups.1.%:3 service_groups.1.node.%:2 service_groups.1.node.compute.%:2 service_groups.1.node.compute.cpu:8 service_groups.1.node.compute.ram:32 service_groups.1.node.disk.%:4 service_groups.1.node.disk.iops:3001 service_groups.1.node.disk.storage:51 service_groups.1.node.disk.type:gp3 service_groups.1.num_of_nodes:2 service_groups.1.services.#:2 service_groups.1.services.0:index service_groups.1.services.1:query support.%:2 support.plan:enterprise support.timezone:IST]--- PASS: TestAccClusterResourceWithOnlyReqFieldAWS (904.59s)
PASS
ok github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/resources/acceptance_tests 905.042s
testing: warning: no tests to run
PASS
ok github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/resources/acceptance_tests/security_acceptance_tests (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/schema (cached) [no tests to run]

Required Checklist:

  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if required)
  • I have run make fmt and formatted my code

Further comments

@ajsqr ajsqr marked this pull request as ready for review March 1, 2024 12:22
@ajsqr ajsqr requested a review from a team as a code owner March 1, 2024 12:22
@ajsqr ajsqr requested a review from a team as a code owner March 26, 2024 17:11
Talina06
Talina06 previously approved these changes Mar 26, 2024
internal/errors/errors.go Show resolved Hide resolved
internal/errors/errors.go Outdated Show resolved Hide resolved
internal/api/client.go Show resolved Hide resolved
internal/api/client.go Show resolved Hide resolved
internal/api/client.go Show resolved Hide resolved
@Talina06 Talina06 requested a review from aniket-Kumar-c March 26, 2024 21:15
aniket-Kumar-c
aniket-Kumar-c previously approved these changes Mar 28, 2024
Copy link
Collaborator

@aniket-Kumar-c aniket-Kumar-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsqr ajsqr dismissed stale reviews from aniket-Kumar-c and Talina06 via bd0f73a April 1, 2024 13:49
Copy link

@girishmind girishmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@girishmind
Copy link

@SaicharanCB Tagging you here, so you have visibility.

@Talina06 Talina06 merged commit 33cde5f into couchbasecloud:main Apr 2, 2024
3 of 4 checks passed
@Talina06 Talina06 changed the title AV-73526 | Handle rate limit error [AV-73526] Add support for rate-limiting retries Apr 2, 2024
@Talina06 Talina06 added the enhancement New feature or request label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants