New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCBC-1010: use explicit nullable types where applicable #182

Merged

avsej merged 1 commit into couchbase:main from avsej:PCBC-1010-fix-deprecation-warning-with-nullable-parameters

Oct 2, 2024

Member

avsej commented Oct 2, 2024

Otherwise PHP 8.4 will emit deprecation warning

I used the following regexps to fix it:

when first argument is nullable
```
s@(\([^?,]\+ \$[^,]\+ = null\)@(?\1@g
```
when any other argument is nullable
```
s@, \([^?,]\+ \$[^,]\+ = null\)@, ?\1@g
```


          PCBC-1010: use explicit nullable types where applicable

426056e

Otherwise PHP 8.4 will emit deprecation warning

avsej requested review from thejcfactor, DemetrisChr and Matt-Woz

October 2, 2024 04:43

Matt-Woz approved these changes

View reviewed changes

Contributor

Matt-Woz left a comment

LGTM 👍

avsej merged commit 6c788db into couchbase:main

63 of 69 checks passed

avsej deleted the PCBC-1010-fix-deprecation-warning-with-nullable-parameters branch

October 2, 2024 15:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet