Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCBC-987: Fix consistency vector encoding for FTS #163

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

avsej
Copy link
Member

@avsej avsej commented Apr 22, 2024

No description provided.

@avsej avsej requested review from thejcfactor and Matt-Woz April 22, 2024 19:55
thejcfactor
thejcfactor previously approved these changes Apr 22, 2024
Copy link

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick -- LGTM otherwise (not a breaking change b/c the use of consistency w/ FTS is broken as-is).

Couchbase/SearchOptions.php Outdated Show resolved Hide resolved
Copy link

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@avsej avsej merged commit 486383d into couchbase:main Apr 22, 2024
28 checks passed
@avsej avsej deleted the fix-search-test branch April 22, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants