Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor get_matrices_from_linear_ode function #32

Open
smover opened this issue Jul 13, 2023 · 0 comments
Open

Refactor get_matrices_from_linear_ode function #32

smover opened this issue Jul 13, 2023 · 0 comments

Comments

@smover
Copy link
Collaborator

smover commented Jul 13, 2023

The function implementation duplicates code that we already have. You can replace the implementation of get_matrices_from_linear_odes only with the two lines above.

My proposal is to 1) move the function get_matrices_from_linear_ode as a method of the DynSystem class in barrier/systems.py (so, you would use it as system.get_matrices...() ) and 2) replace the implementation with the two lines above.
So, you will have this function ready just by looking at the interface of a DynSystem.

For now it's ok to keep it as is, we will refactor later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant