Merge pull request #229 from deanblackborough/v2.25.0

v2.25.0
costs-to-expect · Jun 20, 2022 · 6aea67a · 6aea67a
2 parents e787907 + 76c04cc
commit 6aea67a
Show file tree

Hide file tree

Showing 126 changed files with 2,621 additions and 669 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,31 @@
 
 The complete changelog for the Costs to Expect REST API, our changelog follows the format defined at https://keepachangelog.com/en/1.0.0/
 
+## [v2.25.0] - 2022-06-20
+## Added
+- We allow the `collection` parameter for `simple-item` item-type collections.
+- We have added tests for subcategory management, found another bug, whoopee!
+- We have added tests for item type responses.
+- We have added an option response tests for the resource types collection and a resource type.
+- We have added additional resource type tests and created/updated the json-schema files as necessary.
+- We have added a catch-all route for non-matching routes.
+
+## Changed
+- We have renamed the tests directory and corrected the namespaces.
+- We are continuing to update out routes to named routes.
+- We have moved additional responses to the response class.
+- We have updated more response, if a collection is included in a response a `uri` field will contain the relative URI to the relevant collection.
+- We have adjusted the layout of the test section in the README and added a note explaining the meaning of 'Non yet'.
+- We have updated the response when attempting to delete an item with category assignments, rather than return a generic foreign key error, we specifically mention that there are category assignments that need to be removed first.
+- We have cleaned up the response description lang file.
+
+## Fixed
+- Removed an output in a test.
+- Updated the route middleware, invalid decodes should return a 403 for the route.
+- Added a unique validation rule for emails, don't leave the check to the database.
+- Corrected the descriptions in the OPTIONS requests for `item` summaries.
+- The allowed values for `winner_id` should be a category assigned to the item, not all the categories assigned to the resource type.
+
 ## [v2.24.0] - 2022-06-13
 ## Added
 - We have added our first schema files for OPTIONS responses and started working on the tests.

diff --git a/README.md b/README.md
@@ -260,23 +260,27 @@ You can see our progress in the table below. We are hoping to add tests in each
 not too concerned about missing anything as we still have all our tests in Postman, we won't disable our test monitor until 
 our local test suite is as complete as the Postman request tests.
 
-| Controller                          | Progress               |
-|:------------------------------------|:-----------------------|
-| Authentication (Actions)            | Complete (34 Tests)    |
-| Authentication (Responses)          | In Progress (2 Tests)  |
-| CategoryManage (Actions)            | Complete (11 Tests)    |
-| ItemCategoryManage (Actions)        | Not started            |
-| ItemManage (Actions)                | Not started            |
-| ItemPartialTransferManage (Actions) | Not started            |
-| ItemSubcategoryManage (Actions)     | Not started            |
-| ItemTransferManage (Actions)        | Not started            |
-| PermittedUserManage (Actions)       | In Progress (4 Tests)  |
-| PermittedUserView (Responses)       | In Progress (2 Tests)  |
-| RequestManage (Actions)             | Not started            |
-| ResourceManage (Actions)            | Complete (14 Tests)    |
-| ResourceTypeManage (Actions)        | Complete (14 Tests)    |
-| ResourceTypeView (Responses)        | In Progress (3 Tests)  |
-| SubcategoryManage (Actions)         | Not started            |
-| ToolManage (Actions)                | Not started            |
-| Summaries (Responses)               | Not started            |
-| Total                               | In Progress (84 Tests) |
+| Controller                          | Progress |
+|:------------------------------------|:---------|
+| Authentication (Actions)            | 35 Tests |
+| Authentication (Responses)          | 2 Tests  |
+| CategoryManage (Actions)            | 11 Tests |
+| ItemCategoryManage (Actions)        | Non yet* |
+| ItemManage (Actions)                | Non yet* |
+| ItemPartialTransferManage (Actions) | Non yet* |
+| ItemSubcategoryManage (Actions)     | Non yet* |
+| ItemTransferManage (Actions)        | Non yet* |
+| ItemTypeView (Responses)            | 7 tests  |
+| PermittedUserManage (Actions)       | 4 Tests  |
+| PermittedUserView (Responses)       | 2 Tests  |
+| RequestManage (Actions)             | Non yet* |
+| ResourceManage (Actions)            | 14 Tests |
+| ResourceTypeManage (Actions)        | 14 Tests |
+| ResourceTypeView (Responses)        | 11 Tests |
+| SubcategoryManage (Actions)         | 12 Tests |
+| ToolManage (Actions)                | Non yet* |
+| Summaries (Responses)               | Non yet* |
+| **Total tests**                     | **112**  |
+
+*Non yet does not mean there are no tests, it just means there are no PHPUnit tests. There are over 2000 tests in 
+a private Postman collection, I'm slowing transferring them locally.
diff --git a/tests/CreatesApplication.php → Tests/CreatesApplication.php b/tests/CreatesApplication.php → Tests/CreatesApplication.php