Corrected descriptions

- Updated item summary descriptions, all referred to TCO which is only accurate for one item-type
costs-to-expect · Jun 19, 2022 · 615b3ec · 615b3ec
1 parent 6df7b9b
commit 615b3ec
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 11 deletions.
diff --git a/app/HttpOptionResponse/Item/Summary/AllocatedExpense.php b/app/HttpOptionResponse/Item/Summary/AllocatedExpense.php
@@ -18,7 +18,7 @@ public function create()
             ->setSearchableParameters(LaravelConfig::get($base_path . '.summary-searchable', []))
             ->setFilterableParameters(LaravelConfig::get($base_path . '.summary-filterable', []))
             ->setDynamicParameters($this->allowed_parameters)
-            ->setDescription('route-descriptions.summary_GET_resource-type_resource_items')
+            ->setDescription('route-descriptions.summary_items_GET_index')
             ->setAuthenticationStatus($this->permissions['view'])
             ->option();
 

diff --git a/app/HttpOptionResponse/Item/Summary/Game.php b/app/HttpOptionResponse/Item/Summary/Game.php
@@ -18,7 +18,7 @@ public function create()
             ->setSearchableParameters(LaravelConfig::get($base_path . '.summary-searchable', []))
             ->setFilterableParameters(LaravelConfig::get($base_path . '.summary-filterable', []))
             ->setDynamicParameters($this->allowed_parameters)
-            ->setDescription('route-descriptions.summary_GET_resource-type_resource_items')
+            ->setDescription('route-descriptions.summary_items_GET_index')
             ->setAuthenticationStatus($this->permissions['view'])
             ->option();
 

diff --git a/app/HttpOptionResponse/Item/Summary/SimpleExpense.php b/app/HttpOptionResponse/Item/Summary/SimpleExpense.php
@@ -18,7 +18,7 @@ public function create()
             ->setSearchableParameters(LaravelConfig::get($base_path . '.summary-searchable', []))
             ->setFilterableParameters(LaravelConfig::get($base_path . '.summary-filterable', []))
             ->setDynamicParameters($this->allowed_parameters)
-            ->setDescription('route-descriptions.summary_GET_resource-type_resource_items')
+            ->setDescription('route-descriptions.summary_items_GET_index')
             ->setAuthenticationStatus($this->permissions['view'])
             ->option();
 

diff --git a/app/HttpOptionResponse/Item/Summary/SimpleItem.php b/app/HttpOptionResponse/Item/Summary/SimpleItem.php
@@ -18,7 +18,7 @@ public function create()
             ->setSearchableParameters(LaravelConfig::get($base_path . '.summary-searchable', []))
             ->setFilterableParameters(LaravelConfig::get($base_path . '.summary-filterable', []))
             ->setDynamicParameters($this->allowed_parameters)
-            ->setDescription('route-descriptions.summary_GET_resource-type_resource_items')
+            ->setDescription('route-descriptions.summary_items_GET_index')
             ->setAuthenticationStatus($this->permissions['view'])
             ->option();
 

diff --git a/app/HttpOptionResponse/ResourceTypeItem/Summary/AllocatedExpense.php b/app/HttpOptionResponse/ResourceTypeItem/Summary/AllocatedExpense.php
@@ -17,7 +17,7 @@ public function create()
             ->setParameters(LaravelConfig::get($base_path . '.summary-parameters', []))
             ->setFilterableParameters(LaravelConfig::get($base_path . '.summary-filterable', []))
             ->setDynamicParameters($this->allowed_parameters)
-            ->setDescription('route-descriptions.summary-resource-type-item-GET-index')
+            ->setDescription('route-descriptions.summary_resource_type_items_GET_index')
             ->setAuthenticationStatus($this->permissions['view'])
             ->option();
 

diff --git a/app/HttpOptionResponse/ResourceTypeItem/Summary/Game.php b/app/HttpOptionResponse/ResourceTypeItem/Summary/Game.php
@@ -17,7 +17,7 @@ public function create()
             ->setParameters(LaravelConfig::get($base_path . '.summary-parameters', []))
             ->setFilterableParameters(LaravelConfig::get($base_path . '.summary-filterable', []))
             ->setDynamicParameters($this->allowed_parameters)
-            ->setDescription('route-descriptions.summary-resource-type-item-GET-index')
+            ->setDescription('route-descriptions.summary_resource_type_items_GET_index')
             ->setAuthenticationStatus($this->permissions['view'])
             ->option();
 

diff --git a/app/HttpOptionResponse/ResourceTypeItem/Summary/SimpleExpense.php b/app/HttpOptionResponse/ResourceTypeItem/Summary/SimpleExpense.php
@@ -17,7 +17,7 @@ public function create()
             ->setParameters(LaravelConfig::get($base_path . '.summary-parameters', []))
             ->setFilterableParameters(LaravelConfig::get($base_path . '.summary-filterable', []))
             ->setDynamicParameters($this->allowed_parameters)
-            ->setDescription('route-descriptions.summary-resource-type-item-GET-index')
+            ->setDescription('route-descriptions.summary_resource_type_items_GET_index')
             ->setAuthenticationStatus($this->permissions['view'])
             ->option();
 

diff --git a/app/HttpOptionResponse/ResourceTypeItem/Summary/SimpleItem.php b/app/HttpOptionResponse/ResourceTypeItem/Summary/SimpleItem.php
@@ -17,7 +17,7 @@ public function create()
             ->setParameters(LaravelConfig::get($base_path . '.summary-parameters', []))
             ->setFilterableParameters(LaravelConfig::get($base_path . '.summary-filterable', []))
             ->setDynamicParameters($this->allowed_parameters)
-            ->setDescription('route-descriptions.summary-resource-type-item-GET-index')
+            ->setDescription('route-descriptions.summary_resource_type_items_GET_index')
             ->setAuthenticationStatus($this->permissions['view'])
             ->option();
 

diff --git a/resources/lang/en/route-descriptions.php b/resources/lang/en/route-descriptions.php
@@ -107,7 +107,6 @@
     'summary-resource-type-GET-index' => 'Return a summary of the resource types',
     'summary-resource-GET-index' => 'Return a summary of the resources',
 
-    'summary_GET_resource-type_resource_items' => 'Return the TCO (Total cost of ownership, sum of items) for the selected resource',
-
-    'summary-resource-type-item-GET-index' => 'Return a summary of the items for all the resources matching this resource type',
+    'summary_items_GET_index'=> 'Return the "item" summary for the selected resource, review summary filters for all summary options',
+    'summary_resource_type_items_GET_index'=> 'Return the "item" summary for the selected resource type, items for all resources are summarised, review summary filters for all summary options',
 ];