improve log readability #3379
Merged
improve log readability #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stana-miric
requested review from
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
dusan-maksimovic
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a section in readme file related to unsafe-start-local-validator command. The section describes how to prevent logging of misleading log messages that might appear if some node msgs are attempt to be replayed to the blockchain. Since we don't need this replay data because we are creating new block with the new(replaced validator), the content can be deleted and the log wont show the error logs similar to this:
2:52PM INF Replay: Vote blockID=C80F67CDC3EFDB6E3496605908EFBDEA0A73E58315E9B34A3491C3383702D8F4:1:5ED0B863FBFA extSigLen=0 extensionLen=0 height=22453073 module=consensus peer=7314c477c9d7fea4e2ebf51581f2324971260494 round=0 type=SIGNED_MSG_TYPE_PRECOMMIT
2:52PM INF failed attempting to add vote err="cannot find validator 151 in valSet of size 1: invalid validator index" module=consensus
2:52PM ERR failed to process message err="error adding vote" height=22453074 module=consensus msg_type=*consensus.VoteMessage peer=7314c477c9d7fea4e2ebf51581f2324971260494 round=0