Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: submission of broken invariants #3346

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Sep 18, 2024

Description

Closes: #3345

Fix submission of broken invariants

Reason:

  • passing uninitialized bankkeeper and accountkeeper when creating crisis keeper causes a failure when handling verify invariant messages

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@bermuell bermuell self-assigned this Sep 18, 2024
@bermuell bermuell marked this pull request as ready for review September 18, 2024 10:32
@MSalopek
Copy link
Contributor

Could you explain why moving the crisis keeper registration lower in the file solves the problem (or why)?

@bermuell
Copy link
Contributor Author

Could you explain why moving the crisis keeper registration lower in the file solves the problem (or why)?

Creation of the crisis keeper using uninitialized BankKeeper and AccountKeeper is the reason for the failures. Moving it after the initialization of these two keepers solves the issue.

@bermuell bermuell requested a review from mpoke September 18, 2024 12:12
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bermuell bermuell merged commit 420ac1e into main Sep 18, 2024
17 checks passed
@bermuell bermuell deleted the bernd/3345-invariantsubmission branch September 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Sending proof for broken invariants is not possible
3 participants