Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mapper to sqlalchemy 1.4 #44

Open
wants to merge 147 commits into
base: master
Choose a base branch
from
Open

Update mapper to sqlalchemy 1.4 #44

wants to merge 147 commits into from

Conversation

lotusirous
Copy link

The mapper() is deprecated since 1.4.
This pull request also fixes #41

hjwp added 30 commits February 23, 2021 16:37
@hjwp
ORM for _allocations set on Batch
fff68bd
@hjwp
repository tests
8dae126
@hjwp
repository for batches [chapter_02_repository_ends]
b635a15
@hjwp
first api tests [first_api_test]
fda077d
@hjwp
all the dockerfile gubbins
15902a6
@hjwp
first cut of flask app [first_cut_flask_app]
8fc086e
@hjwp
test persistence by double-allocating. [second_api_test]
158e760
@hjwp
need to commit [flask_commit]
d0ee7ad
@hjwp
test some 400 error cases [test_error_cases]
f20c479
@hjwp
flask now does error handling [flask_error_handling]
80dece9
@hjwp
first tests for the services layer [first_services_tests]
a1903fa
@hjwp
FakeRepository [fake_repo]
9fe9a3d
@hjwp
FakeSession [fake_session]
15b9bf7
@hjwp
test commmits [second_services_test]
eded7eb
@hjwp
services layer with valid-sku check [service_function]
d1e2e6e
@hjwp
modify flask app to use service layer [flask_app_using_service_layer]
cf2f52b
@hjwp
strip out unecessary tests from e2e layer [fewer_e2e_tests]
b537364
@hjwp
fix conftest waits and travis config [chapter_04_service_layer_ends]
952a3d2
@hjwp
move to a more nested folder structure
bdf8fe9
@hjwp
nest the tests too
1bb572a
@hjwp
get all tests passing
db89218
@hjwp
rewrite service layer to take primitives [service_takes_primitives]
c5822aa
@hjwp
services tests partially converted to primitives [tests_call_with_pri…
f341bee 
…mitives]
@hjwp
fixture function for batches [services_factory_function]
1e1f238
@hjwp
new service to add a batch [add_batch_service]
5c953da
@hjwp
service-layer test for add batch [test_add_batch]
262eec0
@hjwp
all service-layer tests now services [services_tests_all_services]
c8fbb60
@hjwp
modify flask app to use new service layer api [api_uses_modified_serv…
96301d2 
…ice]
@hjwp
add api endpoint for add_batch [api_for_add_batch]
6b404b5
@hjwp
api tests no longer need hardcoded sql fixture [chapter_05_high_gear_…
fd45a6f 
…low_gear_ends]
hjwp and others added 26 commits February 24, 2021 20:08
@hjwp
use self.handlers for handle_event and handle_command [messagebus_han…
e9ae6db 
…dlers_change]
@hjwp
conftest change to backport, session_factory -> sqlite_session_factory
82d7908
@hjwp
conftest change to backport to ch 5, isolation serializable in all pg…
36b2c82 
… tests
@hjwp
uow tests maybe backport, pass explicit uow to threads
5b05570
@hjwp
bootstrap script preps DI'd handlers and start orm [bootstrap_script]
c3282c9
@hjwp
use bootstrap in service layer tests [bootstrap_tests]
f923760
@hjwp
fixture to start mappers explicitly, use in repo and uow tests
e883f20
@hjwp
fix view tests to use bootstrap. [bootstrap_view_tests]
c6f9429
@hjwp
use bootstrap in flask [flask_calls_bootstrap]
d4a8674
@hjwp
use bootstrap for redis
4ca05b0
@hjwp
experiment with nonmagic DI zzzz [nomagic_di]
5f9b143
@hjwp
Revert "experiment with nonmagic DI zzzz"
2e5e5de 
This reverts commit f42b193857eec8560443767de9fd7ada9f2acb96.
@hjwp
switch to a notifications class [notifications_class]
09c0214
@hjwp
tests for notifcations [notifications_unit_tests]
0943337
@hjwp
add a mailhog fake email server to docker-compose
3f1d63d
@hjwp
logging.info needs backport
c112af9
@hjwp
integration test for emails [chapter_13_dependency_injection_ends]
5d8136c
@hjwp
update travis config
2c62b9d
@hjwp
readme fixes
4157d6d
@hjwp
attempt docker login
79392e8
@hjwp
upgrade travis to focal + 3.9 why the heck not
3ed6ff0
@GeyseR
fix requirements installation command in README
2045cd7
@hjwp
Merge pull request cosmicpython#30 from GeyseR/patch-1
9471128 
fix requirements installation command in README
@adamculp
Corrected commands of the individual tests make commands
28b984e
@hjwp
Merge pull request cosmicpython#32 from adamculp/master
69a88f8 
Corrected commands of the individual tests make commands
@lotusirous
Update mapper to sqlalchemy 1.4
7e95928
staticdev
staticdev approved these changes Nov 25, 2021
View reviewed changes
Copy link

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is the new way I mentioned.

@kazyakj kazyakj mentioned this pull request Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donghyeon-kim98 donghyeon-kim98 donghyeon-kim98 approved these changes

@staticdev staticdev staticdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mapper is deprecated on SQLAlchemy 1.4+
6 participants
@lotusirous @staticdev @donghyeon-kim98 @hjwp @GeyseR @adamculp