Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with lists #42

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix issues with lists #42

merged 2 commits into from
Nov 6, 2024

Conversation

edfloreshz
Copy link
Member

@edfloreshz edfloreshz commented Nov 6, 2024

List actions now receive an optional entity depending on where the action was triggered, either the menu or the context menu, this allows the actions to be performed on the selected entity rather than the active one for the context menu.

  • Renaming no longer removes the list icon.
  • Renaming or setting an icon also updates the content view.

Closes #25

- renaming no longer removes the list icon
- renaming or setting an icon also updates the content view.
List actions now receive an optional entity depending on where the action was triggered, either the menu or from the context menu,
this allows the actions to be performed on the selected entity rather than the active one for the context menu.
@edfloreshz edfloreshz added the bug Something isn't working label Nov 6, 2024
@edfloreshz edfloreshz requested a review from a team November 6, 2024 18:29
@edfloreshz edfloreshz self-assigned this Nov 6, 2024
@edfloreshz edfloreshz merged commit 6c479a0 into main Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming list removes prefix icon from list
1 participant