Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water restriction ref pct #847

Merged
merged 2 commits into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion alyx/actions/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,10 @@ def get(self, request, format=None, nickname=None):
end_date = request.query_params.get('end_date', None)
subject = Subject.objects.get(nickname=nickname)
records = subject.water_control.to_jsonable(start_date=start_date, end_date=end_date)
data = {'subject': nickname, 'implant_weight': subject.implant_weight, 'records': records}
data = {'subject': nickname, 'implant_weight': subject.implant_weight,
'reference_weight_pct': subject.water_control.reference_weight_pct,
'zscore_weight_pct': subject.water_control.zscore_weight_pct,
'records': records}
return Response(data)


Expand Down
5 changes: 4 additions & 1 deletion alyx/actions/water_control.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from operator import attrgetter, itemgetter
import os.path as op

from django.conf import settings
from django.urls import reverse
from django.utils.html import format_html
from django.http import HttpResponse
Expand Down Expand Up @@ -563,7 +564,9 @@ def water_control(subject):
implant_weight=subject.implant_weight
)
wc.add_threshold(percentage=rw_pct + zw_pct, bgcolor=PALETTE['orange'], fgcolor='#FFC28E')
wc.add_threshold(percentage=.7, bgcolor=PALETTE['red'], fgcolor='#F08699', line_style='--')
if absolute_min := settings.WEIGHT_THRESHOLD:
wc.add_threshold(
percentage=absolute_min, bgcolor=PALETTE['red'], fgcolor='#F08699', line_style='--')
# Water restrictions.
wrs = sorted(list(subject.actions_waterrestrictions.all()), key=attrgetter('start_time'))
# Reference weight.
Expand Down
2 changes: 1 addition & 1 deletion alyx/alyx/settings_lab_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
DEFAULT_PROTOCOL = '1'
SUPERUSERS = ('root',)
STOCK_MANAGERS = ('root',)
WEIGHT_THRESHOLD = 0.75
WEIGHT_THRESHOLD = 0.8 # Absolute minimum weight threshold (red line in plots)
DEFAULT_LAB_NAME = 'defaultlab'
WATER_RESTRICTIONS_EDITABLE = False # if set to True, all users can edit water restrictions
DEFAULT_LAB_PK = '4027da48-7be3-43ec-a222-f75dffe36872'
Expand Down
10 changes: 10 additions & 0 deletions alyx/subjects/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,18 @@ def get_reference_weight(self, obj):
def get_last_water_restriction(self, obj):
return obj.water_control.water_restriction_at()

def get_reference_weight_pct(self, obj):
return obj.water_control.reference_weight_pct

def get_zscore_weight_pct(self, obj):
return obj.water_control.zscore_weight_pct

expected_water = serializers.SerializerMethodField()
remaining_water = serializers.SerializerMethodField()
reference_weight = serializers.SerializerMethodField()
last_water_restriction = serializers.SerializerMethodField()
reference_weight_pct = serializers.SerializerMethodField()
zscore_weight_pct = serializers.SerializerMethodField()


class WaterRestrictedSubjectListSerializer(_WaterRestrictionBaseSerializer):
Expand All @@ -42,6 +50,8 @@ class Meta:
'remaining_water',
'reference_weight',
'last_water_restriction',
'reference_weight_pct',
'zscore_weight_pct'
)

lookup_field = 'nickname'
Expand Down
3 changes: 1 addition & 2 deletions scripts/sync_ucl/prune_cortexlab.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@

# the sessions should also have the cortexlab lab field properly labeled before import
if Lab.objects.using('cortexlab').filter(name='cortexlab').count() == 0:
lab_dict = {'pk': CORTEX_LAB_PK,
'name': 'cortexlab'}
lab_dict = {'pk': CORTEX_LAB_PK, 'name': 'cortexlab'}
lab = Lab.objects.using('cortexlab').create(**lab_dict)
lab.save()
else:
Expand Down
Loading