CUDA 12.4 #227
Merged
CUDA 12.4 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitemyapp
force-pushed
the
bitemyapp/cuda-12040
branch
from
63d47da to
916ed2d
Compare
coreylowman
reviewed
May 3, 2024
|
That's weird regarding the boolean dtype. I'm thinking we can merge this for now and fix that in a patch version if it comes up as an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226
No idea if I did this right. I had some mystifying issues with the types until I added
cudnn_backend.hto the wrapper header for the bindgen.Remaining issue: no idea what happened to
CUDNN_DATA_BOOLEAN.It uhh, disappeared? I can't find anything in the CUDA 12.4 release notes about this so I have to believe that I've done something wrong on that account. Fortunately, I'm not using cuDNN and don't know why I would want bools so I don't think it's a blocker for what I'm doing.