-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade WinSW to 2.0.1 #268
base: master
Are you sure you want to change the base?
Conversation
I'll consider this, depending on how much time I get. I've been working on an alternative to winsw, so this may not be necessary. |
We're now building WinSW 3, and it's surprising to see this project is still using WinSW 1. A large number of issues in this repo have been resolved in the upstream.
Why reinvent the wheel? Is it written in Golang? |
Yes, alternative is in Go. It's not recreating the wheel for me, because I'm building it for another effort. Again, not opposed to merging this, I just need to test it/confirm and make sure I can continue to support it. |
Sounds good. I'm also considering rewriting WinSW in a different language, but I don't regard Go as a competitive choice. I would prefer a native language like Rust this time. |
Would this also address issue #53 and allow |
Yeah. There may be more ancient issues fixed |
Curious. I looked at the commit. All the 'Bug Fixes' listed here. Those are fixes in WinSW I assume? Since commit simply updated the executable. |
WinSW 2 carries a logging framework so the binary is a bit larger.
Also removes .NET 2 support. Who is using .NET 2 these days?
Fixes #47
Bug fixes
waithint
,sleeptime
,resetfailure
, andstoptimeout
options from XML configs with metadata beforesettings
.uninstall
command when the service cannot be uninstalled immediately.stoparguments
are defined withoutstopexecutable
in the XML file.Process.Kill()
if the process actually exits.Compatibility notes