Update timer to be more in-line with dnf-automatic

[alexhaydock]

This suggestion would update the timer behaviour of rpm-ostreed-automatic.timer to be more in line with the behaviour of dnf-automatic.timer.

Problem Statement

On a laptop which spends a lot of time in sleep mode, the timer frequency used by rpm-ostreed-automatic.timer is so infrequent that the service rarely ends up running.

To solve this, we can add

Persistent=true

This brings the behaviour into line with how dnf-automatic.timer works:

https://github.com/rpm-software-management/dnf/blob/69d1f641cda28fc543846524d15ec7291baf3e5a/etc/systemd/dnf-automatic.timer#L10

Just adding this alone can cause issues in environments with slow network bring-up, so we can also add:

Wants=network-online.target

Which also matches the dnf-automatic.timer behaviour:

I've also added:

After=network-online.target

as a suggestion here, as the systemd docs suggest this might be more robust than just using Wants=.

[openshift-ci]

Hi @alexhaydock. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jmarrero]

/ok-to-test

[jmarrero]

Thank you for your PR and detailed description @alexhaydock
This seems like a good idea to me, I don't see any reason this would break any expected behavior on servers either.

[jmarrero]

lgtm

[cgwalters]

Thanks!