-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel-install: integration #5135
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
74d2f7e
to
04dcac2
Compare
todo here:
|
Joseph and I were looking at #4950 - I'd forgotten about that change when looking at this one. This is all quite messy because we need to handle 2 different cases with the updated rpm-ostree (i.e. after this PR).
In the first case, we must just go into our existing kernel handling and not assume the real
I would lean to unconditionally doing the first...we shouldn't try to have it two different ways in the second. Basically let's test stuff well, and then pull the trigger on the base image side and always go through the real |
Signed-off-by: Colin Walters <[email protected]>
We also correctly parse the arguments passed on kernel-install.
04dcac2
to
3a4f740
Compare
incorporates #5097
closes: #4726
This will pair with: https://gitlab.com/fedora/bootc/base-images/-/merge_requests/62 which makes the integration work.
This builds and works on the following Containerfile.
Need to figure out how to properly deal with the commented out code still.